From 922620ed3e334d27996396c0253733c2be831b1c Mon Sep 17 00:00:00 2001 From: Joan Fontanals Martinez Date: Mon, 24 Jan 2022 13:01:09 +0100 Subject: [PATCH] feat: change pydantic model optional id --- docarray/document/pydantic_model.py | 2 +- tests/unit/test_pydantic.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docarray/document/pydantic_model.py b/docarray/document/pydantic_model.py index b332c578a7c..1b560f1096f 100644 --- a/docarray/document/pydantic_model.py +++ b/docarray/document/pydantic_model.py @@ -28,7 +28,7 @@ class _NamedScore(BaseModel): class PydanticDocument(BaseModel): - id: str + id: Optional[str] parent_id: Optional[str] granularity: Optional[int] adjacency: Optional[int] diff --git a/tests/unit/test_pydantic.py b/tests/unit/test_pydantic.py index 074f162852f..ca645b3bf6c 100644 --- a/tests/unit/test_pydantic.py +++ b/tests/unit/test_pydantic.py @@ -160,3 +160,7 @@ def test_to_from_with_blob(protocol, to_fn, blob): assert d.blob == r_d.blob if d.blob: assert isinstance(r_d.blob, bytes) + + +def test_pydantic_not_id(): + _ = PydanticDocument()