diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index 1853247e9f9..ccd020109e1 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -146,6 +146,8 @@ jobs: check-readme-modification: runs-on: ubuntu-latest + outputs: + readme_changed: ${{ steps.step_output.outputs.readme_changed }} steps: - uses: actions/checkout@v3 with: @@ -159,16 +161,13 @@ jobs: README.md - name: Check if README is modified + id: step_output if: steps.changed-files-specific.outputs.any_changed == 'true' run: | - echo "README.md is modified" - touch SUCCESS - - - name: Return outputs - run: | - [[ -f SUCCESS ]] + echo "readme_changed=true" >> $GITHUB_OUTPUT publish-docarray-org: needs: check-readme-modification + if: needs.check-readme-modification.outputs.readme_changed == 'true' uses: ./.github/workflows/publish-docarray-org.yml secrets: inherit \ No newline at end of file diff --git a/.github/workflows/publish-docarray-org.yml b/.github/workflows/publish-docarray-org.yml index 8e52c03fa7f..23250e7b188 100644 --- a/.github/workflows/publish-docarray-org.yml +++ b/.github/workflows/publish-docarray-org.yml @@ -31,7 +31,7 @@ jobs: - name: Check trigger event run: | touch SUCCESS - if: github.event_name == 'pull_request' + if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }} - name: Fail release token run: | [[ -f SUCCESS ]] diff --git a/README.md b/README.md index b9c7aaa1f3a..cbb79461ed8 100644 --- a/README.md +++ b/README.md @@ -167,10 +167,10 @@ Let's use DocArray and the [Totally Looks Like](https://sites.google.com/view/to - Visualizing top-9 matches using DocArray API - Visualizing top-9 matches using DocArray API - Visualizing top-9 matches using DocArray API - Visualizing top-9 matches using DocArray API + Visualizing top-9 matches using DocArray API + Visualizing top-9 matches using DocArray API + Visualizing top-9 matches using DocArray API + Visualizing top-9 matches using DocArray API @@ -206,7 +206,7 @@ left_da.plot_image_sprites() ```

-Load totally looks like dataset with docarray API +Load totally looks like dataset with docarray API

### Apply preprocessing @@ -252,7 +252,7 @@ left_da.plot_embeddings(image_sprites=True) ```

-Visualizing embedding via tSNE and embedding projector +Visualizing embedding via tSNE and embedding projector

Fun is fun, but recall our goal is to match left images against right images and so far we have only handled the left. Let's repeat the same procedure for the right: