From 0cd929f34b8a76bebd326d1a5cc51459cafa706b Mon Sep 17 00:00:00 2001 From: anna-charlotte Date: Mon, 2 Jan 2023 09:44:44 +0100 Subject: [PATCH 1/2] fix: replace newline with whitespace to fix display in plot embeddings Signed-off-by: anna-charlotte --- docarray/array/mixins/io/csv.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docarray/array/mixins/io/csv.py b/docarray/array/mixins/io/csv.py index c5d4dab3c2a..41c05caa298 100644 --- a/docarray/array/mixins/io/csv.py +++ b/docarray/array/mixins/io/csv.py @@ -86,6 +86,8 @@ def save_csv( if flatten_tags: t = pd.pop('tags') pd.update({f'tag__{k}': v for k, v in t.items()}) + + pd = {k: str(v).replace('\n', ' ') for k, v in pd.items()} writer.writerow(pd) @classmethod From 01a66781d9c1400b0f89a4b1e74500e083d5d1e4 Mon Sep 17 00:00:00 2001 From: anna-charlotte Date: Mon, 2 Jan 2023 11:00:36 +0100 Subject: [PATCH 2/2] refactor: rename pd to doc_dict Signed-off-by: anna-charlotte --- docarray/array/mixins/io/csv.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docarray/array/mixins/io/csv.py b/docarray/array/mixins/io/csv.py index 41c05caa298..d7f8731b440 100644 --- a/docarray/array/mixins/io/csv.py +++ b/docarray/array/mixins/io/csv.py @@ -78,17 +78,17 @@ def save_csv( writer.writeheader() for d in self: - pd = d.to_dict( + doc_dict = d.to_dict( protocol='jsonschema', exclude=set(exclude_fields) if exclude_fields else None, exclude_none=True, ) if flatten_tags: - t = pd.pop('tags') - pd.update({f'tag__{k}': v for k, v in t.items()}) + t = doc_dict.pop('tags') + doc_dict.update({f'tag__{k}': v for k, v in t.items()}) - pd = {k: str(v).replace('\n', ' ') for k, v in pd.items()} - writer.writerow(pd) + doc_dict = {k: str(v).replace('\n', ' ') for k, v in doc_dict.items()} + writer.writerow(doc_dict) @classmethod def load_csv(