From 7d507286b6c0ec54930751fac38863038de25767 Mon Sep 17 00:00:00 2001 From: Han Xiao Date: Fri, 4 Feb 2022 15:38:19 +0100 Subject: [PATCH 1/2] fix(store): change default serialization protocol to pickle --- docarray/array/storage/sqlite/backend.py | 2 +- docarray/array/storage/weaviate/backend.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docarray/array/storage/sqlite/backend.py b/docarray/array/storage/sqlite/backend.py index 4332467c964..fe9627be194 100644 --- a/docarray/array/storage/sqlite/backend.py +++ b/docarray/array/storage/sqlite/backend.py @@ -34,7 +34,7 @@ def _sanitize_table_name(table_name: str) -> str: class SqliteConfig: connection: Optional[Union[str, 'sqlite3.Connection']] = None table_name: Optional[str] = None - serialize_config: Dict = field(default_factory=lambda: {'protocol': 'protobuf'}) + serialize_config: Dict = field(default_factory=dict) conn_config: Dict = field(default_factory=dict) journal_mode: str = 'DELETE' synchronous: str = 'OFF' diff --git a/docarray/array/storage/weaviate/backend.py b/docarray/array/storage/weaviate/backend.py index 07a0e642636..df08cef46d7 100644 --- a/docarray/array/storage/weaviate/backend.py +++ b/docarray/array/storage/weaviate/backend.py @@ -33,7 +33,7 @@ class WeaviateConfig: client: Optional[Union[str, weaviate.Client]] = None n_dim: Optional[int] = None name: Optional[str] = None - serialize_config: Dict = field(default_factory=lambda: {'protocol': 'protobuf'}) + serialize_config: Dict = field(default_factory=dict) class BackendMixin(BaseBackendMixin): From 9f60014e22b8a6b976abfa2b6b11dd623358e62c Mon Sep 17 00:00:00 2001 From: Han Xiao Date: Fri, 4 Feb 2022 16:18:42 +0100 Subject: [PATCH 2/2] docs(store): add documentation for storage backend --- tests/unit/array/mixins/test_embed.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/array/mixins/test_embed.py b/tests/unit/array/mixins/test_embed.py index b453fc39c9d..0ae985e1650 100644 --- a/tests/unit/array/mixins/test_embed.py +++ b/tests/unit/array/mixins/test_embed.py @@ -43,7 +43,7 @@ ) -@pytest.mark.parametrize('framework', ['onnx', 'keras', 'pytorch', 'paddle']) +@pytest.mark.parametrize('framework', ['onnx', 'keras', 'pytorch']) @pytest.mark.parametrize( 'da', [DocumentArray, DocumentArraySqlite, DocumentArrayWeaviate] )