Skip to content

Fix issue #24. srt languages are applied to srt offsets/#25

Merged
lisamelton merged 1 commit intolisamelton:masterfrom
arikalish:issue_24-sr_offset_missing
Sep 4, 2015
Merged

Fix issue #24. srt languages are applied to srt offsets/#25
lisamelton merged 1 commit intolisamelton:masterfrom
arikalish:issue_24-sr_offset_missing

Conversation

@arikalish
Copy link
Copy Markdown
Contributor

@arikalish arikalish commented Sep 2, 2015

Hi Don,

This fixes issue #24 that I opened up earlier tonight. Tested with my input files and got the expected output:

./transcode-video.rb --crop 0:0:0:0 -o /Volumes/Videos/Converted/Up.m4v --add-audio 2 --copy-audio 2 --add-srt Up.srt --bind-srt-language eng --bind-srt-offset 0 --dry-run Up_\(Disc_1\)_t00.mkv 
HandBrakeCLI --input=Up_\(Disc_1\)_t00.mkv --output=/Volumes/Videos/Converted/Up.m4v --markers --encoder=x264 --quality=16 --crop=0:0:0:0 --strict-anamorphic --rate=30 --pfr --audio=1,1,2 --aencoder=ca_aac,ac3,copy --audio-fallback=ac3 --ab=,384, --srt-file=Up.srt --srt-offset=0 --srt-lang=eng --encopts=vbv-maxrate=5000:vbv-bufsize=2500:crf-max=25

./transcode-video.rb --crop 0:0:0:0 -o /Volumes/Videos/Converted/Up.m4v --add-audio 2 --copy-audio 2 --add-srt Up.srt --bind-srt-offset 100 --dry-run Up_\(Disc_1\)_t00.mkv 
HandBrakeCLI --input=Up_\(Disc_1\)_t00.mkv --output=/Volumes/Videos/Converted/Up.m4v --markers --encoder=x264 --quality=16 --crop=0:0:0:0 --strict-anamorphic --rate=30 --pfr --audio=1,1,2 --aencoder=ca_aac,ac3,copy --audio-fallback=ac3 --ab=,384, --srt-file=Up.srt --srt-offset=100 --encopts=vbv-maxrate=5000:vbv-bufsize=2500:crf-max=25

./transcode-video.rb --crop 0:0:0:0 -o /Volumes/Videos/Converted/Up.m4v --add-audio 2 --copy-audio 2 --add-srt Up.srt --bind-srt-language eng --bind-srt-offset 100 --dry-run Up_\(Disc_1\)_t00.mkv 
HandBrakeCLI --input=Up_\(Disc_1\)_t00.mkv --output=/Volumes/Videos/Converted/Up.m4v --markers --encoder=x264 --quality=16 --crop=0:0:0:0 --strict-anamorphic --rate=30 --pfr --audio=1,1,2 --aencoder=ca_aac,ac3,copy --audio-fallback=ac3 --ab=,384, --srt-file=Up.srt --srt-offset=100 --srt-lang=eng --encopts=vbv-maxrate=5000:vbv-bufsize=2500:crf-max=25

Ari

@lisamelton
Copy link
Copy Markdown
Owner

lisamelton commented Sep 2, 2015

@arikalish That certainly looks like a copy/past error on my part, doesn't it? :)

OK, I'll take this patch as soon as I get back home to test it.

@arikalish
Copy link
Copy Markdown
Contributor Author

arikalish commented Sep 2, 2015

Yeah, I didn't want to say it :). Easy fix, though!

lisamelton added a commit that referenced this pull request Sep 4, 2015
@lisamelton
Merge pull request #25 from arikalish/issue_24-sr_offset_missing
7e634bd 
Fix issue #24. SRT languages are applied to SRT offsets.
@lisamelton lisamelton merged commit 7e634bd into lisamelton:master Sep 4, 2015
@lisamelton
Copy link
Copy Markdown
Owner

lisamelton commented Sep 4, 2015

@arikalish I'm back home briefly so I just merged the fix online. I'll release this when I get a chance to evaluate a few other fixes and when I'm back (for much longer) next week. Sorry this is taking so long.

@arikalish arikalish deleted the issue_24-sr_offset_missing branch September 4, 2015 14:21
@arikalish
Copy link
Copy Markdown
Contributor Author

arikalish commented Sep 4, 2015

No problem. I've just been running the ruby script directly from a separate location.

@lisamelton lisamelton mentioned this pull request Jan 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arikalish @lisamelton