Skip to content

Fix veryfast preset of handbrakeCLI nightly#36

Merged
lisamelton merged 1 commit intolisamelton:masterfrom
cnrd:patch-2
Jan 8, 2016
Merged

Fix veryfast preset of handbrakeCLI nightly#36
lisamelton merged 1 commit intolisamelton:masterfrom
cnrd:patch-2

Conversation

@cnrd
Copy link
Copy Markdown
Contributor

@cnrd cnrd commented Jan 8, 2016

As we just discussed.

Force handbrakeCLI to use medium preset

Force handbrakeCLI to use medium preset
@lisamelton
Copy link
Copy Markdown
Owner

@cnrd I'll consider but first I want to find out what kind of crack the HandBrake development team has been smoking to make veryfast the default.

In the meantime, when using nightly builds, add -H encoder-preset=medium to your command line to get the default behavior.

@cnrd
Copy link
Copy Markdown
Contributor Author

cnrd commented Jan 8, 2016

Will do!

Thanks :-)

@lisamelton
Copy link
Copy Markdown
Owner

@cnrd OK, it looks like the change to veryfast as the default preset is intentional by the HandBrake development team, however misguided. And it looks like they've changed other defaults. Which means the fix I have to make will likely be more than just the preset.

Stay tuned.

lisamelton added a commit that referenced this pull request Jan 8, 2016
Force `medium` x264 preset to override new `veryfast` default value
in HandBrake nightly builds.
@lisamelton lisamelton merged commit 386aaac into lisamelton:master Jan 8, 2016
@lisamelton
Copy link
Copy Markdown
Owner

@cnrd OK, I took your patch. Thanks.

But I had to fix your spacing (none before commas, please) and rewrap your line. Just be careful with that the next time.

Looks like I won't have to change anything else. But I'll test this for awhile before I release it.

@cnrd
Copy link
Copy Markdown
Contributor Author

cnrd commented Jan 8, 2016

Yeah I see that, sorry that was sloppy coding... I totally agree on only having spaces after a comma. Thanks for fixing it up.

Will be more careful if I propose other patches.

@lisamelton
Copy link
Copy Markdown
Owner

@cnrd No worries, man. Keep the patches coming. :)

@lisamelton
Copy link
Copy Markdown
Owner

@cnrd BTW, are you on Twitter? What's your account name so I can keep an eye on you? :)

@cnrd
Copy link
Copy Markdown
Contributor Author

cnrd commented Jan 9, 2016

I'm @ConradAndersen on Twitter, not that I really write much on there, mostly use it as a newsfeed :-)

@lisamelton
Copy link
Copy Markdown
Owner

@cnrd Ah! I thought that might be you. :)

BTW, I spent the day following up on your fix in a big way. Lots of changes to support HandBrake nightlies. There was far more wrong than I thought. So, I just released version 0.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants