Change spec to new syntax.

piotrmurach · piotrmurach · commit e27b096d77a4 · 2015-12-20T17:20:56.000+01:00
diff --git a/lib/github_api/client/activity/starring.rb b/lib/github_api/client/activity/starring.rb
@@ -2,7 +2,8 @@
 
 module Github
   # Repository Starring is a feature that lets users bookmark repositories.
-  # Stars are shown next to repositories to show an approximate level of interest.  # Stars have no effect on notifications or the activity feed.
+  # Stars are shown next to repositories to show an approximate level of interest.
+  # Stars have no effect on notifications or the activity feed.
   class Client::Activity::Starring < API
     # List stargazers
     #
@@ -21,7 +22,7 @@ def list(*args)
       return response unless block_given?
       response.each { |el| yield el }
     end
-    alias :all :list
+    alias_method :all, :list
 
     # List repos being starred by a user
     #
@@ -54,15 +55,14 @@ def starred(*args)
       response = if (user_name = params.delete('user'))
         get_request("/users/#{user_name}/starred", params)
       else
-        get_request("/user/starred", params)
+        get_request('/user/starred', params)
       end
       return response unless block_given?
       response.each { |el| yield el }
     end
 
     # Check if you are starring a repository
     #
-    #
     # @see https://developer.github.com/v3/activity/starring/#check-if-you-are-starring-a-repository
     #
     # @example
diff --git a/spec/github/client/activity/starring/list_spec.rb b/spec/github/client/activity/starring/list_spec.rb
@@ -29,12 +29,12 @@
     it "should yield iterator if block given" do
       yielded = []
       result = subject.list(user, repo) { |obj| yielded << obj }
-      yielded.should == result
+      expect(yielded).to eq(result)
     end
 
     it "should get the resources" do
       subject.list user, repo
-      a_get(request_path).should have_been_made
+      expect(a_get(request_path)).to have_been_made
     end
 
     it_should_behave_like 'an array of resources' do
@@ -43,7 +43,7 @@
 
     it "should get watcher information" do
       stargazers = subject.list user, repo
-      stargazers.first.login.should == 'octocat'
+      expect(stargazers.first.login).to eq('octocat')
     end
   end
 
diff --git a/spec/github/client/activity/starring/star_spec.rb b/spec/github/client/activity/starring/star_spec.rb
@@ -19,8 +19,8 @@
 
       it "should successfully star a repo" do
         subject.star user, repo
-        a_put(request_path).with(:query => {:access_token => OAUTH_TOKEN}).
-          should have_been_made
+        expect(a_put(request_path).with(:query => {:access_token => OAUTH_TOKEN})).
+          to have_been_made
       end
     end
   end
diff --git a/spec/github/client/activity/starring/starred_spec.rb b/spec/github/client/activity/starring/starred_spec.rb
@@ -19,7 +19,7 @@
       stub_get("/users/#{user}/starred").
         to_return(:body => fixture("repos/starred.json"), :status => 200, :headers => {})
       subject.starred :user => user
-      a_get("/users/#{user}/starred").should have_been_made
+      expect(a_get("/users/#{user}/starred")).to have_been_made
     end
   end
 
@@ -34,20 +34,20 @@
 
     it "should get the resources" do
       subject.starred
-      a_get("/user/starred").with(:query => {:access_token => OAUTH_TOKEN}).
-        should have_been_made
+      expect(a_get("/user/starred").with(:query => {:access_token => OAUTH_TOKEN})).
+        to have_been_made
     end
 
     it "should return array of resources" do
       starred = subject.starred
-      starred.should be_an Enumerable
-      starred.should have(1).items
+      expect(starred).to be_an Enumerable
+      expect(starred.size).to eq(1)
     end
 
     it "should get starred information" do
       starred = subject.starred
-      starred.first.name.should == 'Hello-World'
-      starred.first.owner.login.should == 'octocat'
+      expect(starred.first.name).to eq('Hello-World')
+      expect(starred.first.owner.login).to eq('octocat')
     end
   end
 end # starred
diff --git a/spec/github/client/activity/starring/starring_spec.rb b/spec/github/client/activity/starring/starring_spec.rb
@@ -19,14 +19,14 @@
 
     it "should return false if resource not found" do
       starring = subject.starring? user, repo
-      starring.should be_false
+      expect(starring).to be_false
     end
 
     it "should return true if resoure found" do
         stub_get(request_path).to_return(:body => "[]", :status => 200,
           :headers => {:user_agent => subject.user_agent})
       starring = subject.starring? user, repo
-      starring.should be_true
+      expect(starring).to be_true
     end
   end
 
diff --git a/spec/github/client/activity/starring/unstar_spec.rb b/spec/github/client/activity/starring/unstar_spec.rb
@@ -20,8 +20,8 @@
 
       it "should successfully unstar a repo" do
         subject.unstar user, repo
-        a_delete(request_path).with(:query => {:access_token => OAUTH_TOKEN}).
-          should have_been_made
+        expect(a_delete(request_path).with(:query => {:access_token => OAUTH_TOKEN})).
+          to have_been_made
       end
     end
   end
