fix(apigateway): support dynamic routes with equal sign (RFC3986) (aws-powertools#1737)

heitorlessa · web-flow · commit cb2eb962593c · 2022-11-21T11:30:13.000+01:00
diff --git a/aws_lambda_powertools/event_handler/api_gateway.py b/aws_lambda_powertools/event_handler/api_gateway.py
@@ -40,7 +40,7 @@
 logger = logging.getLogger(__name__)
 
 _DYNAMIC_ROUTE_PATTERN = r"(<\w+>)"
-_SAFE_URI = "-._~()'!*:@,;"  # https://www.ietf.org/rfc/rfc3986.txt
+_SAFE_URI = "-._~()'!*:@,;="  # https://www.ietf.org/rfc/rfc3986.txt
 # API GW/ALB decode non-safe URI chars; we must support them too
 _UNSAFE_URI = "%<> \[\]{}|^"  # noqa: W605
 _NAMED_GROUP_BOUNDARY_PATTERN = rf"(?P\1[{_SAFE_URI}{_UNSAFE_URI}\\w]+)"
diff --git a/tests/functional/event_handler/test_api_gateway.py b/tests/functional/event_handler/test_api_gateway.py
@@ -909,7 +909,7 @@ def get_network_account(account_id: str, network_id: str):
     [
         pytest.param(123456789, id="num"),
         pytest.param("user@example.com", id="email"),
-        pytest.param("-._~'!*:@,;()", id="safe-rfc3986"),
+        pytest.param("-._~'!*:@,;()=", id="safe-rfc3986"),
         pytest.param("%<>[]{}|^", id="unsafe-rfc3986"),
     ],
 )

Original file line number	Diff line number	Diff line change
`@@ -909,7 +909,7 @@ def get_network_account(account_id: str, network_id: str):`
`909`	`909`	`[`
`910`	`910`	`pytest.param(123456789, id="num"),`
`911`	`911`	`pytest.param("[email protected]", id="email"),`
`912`		`- pytest.param("-._~'!*:@,;()", id="safe-rfc3986"),`
	`912`	`+ pytest.param("-._~'!*:@,;()=", id="safe-rfc3986"),`
`913`	`913`	`pytest.param("%<>[]{}\|^", id="unsafe-rfc3986"),`
`914`	`914`	`],`
`915`	`915`	`)`