Restore 100% coverage #51

nelsonic · nelsonic · commit 630979385ffa · 2022-02-07T21:56:20.000Z
diff --git a/lib/elixir_auth_github.ex b/lib/elixir_auth_github.ex
@@ -30,8 +30,7 @@ defmodule ElixirAuthGithub do
   `client_secret/0` returns a `String` of the `GITHUB_CLIENT_SECRET`
   """
   def client_secret do
-    System.get_env("GITHUB_CLIENT_SECRET") ||
-      Application.get_env(:elixir_auth_github, :client_secret)
+    System.get_env("GITHUB_CLIENT_SECRET") || Application.get_env(:elixir_auth_github, :client_secret)
   end
 
   @doc """
diff --git a/test/elixir_auth_github_test.exs b/test/elixir_auth_github_test.exs
@@ -54,16 +54,19 @@ defmodule ElixirAuthGithubTest do
   end
 
   test "github_auth returns an error with a bad code" do
+    setup_test_environment_variables()
     assert ElixirAuthGithub.github_auth("1234") ==
              {:error, %{"error" => "error"}}
   end
 
   test "github_auth returns an error with a bad code 123" do
+    setup_test_environment_variables()
     res = ElixirAuthGithub.github_auth("123")
     assert res == {:error, %{"error" => "test error"}}
   end
 
   test "fetch primary email for user" do
+    setup_test_environment_variables()
     {:ok, res} = ElixirAuthGithub.github_auth("42")
     assert res.email == "private_email@gmail.com"
   end
