Add tests for repo_rename and fixed one logic bug in the rename code

Grokzen · Grokzen · commit 56c23a5eb8bd · 2020-02-11T16:19:00.000+01:00
diff --git a/sgit/core.py b/sgit/core.py
@@ -165,9 +165,9 @@ def repo_rename(self, from_name, to_name):
             print(f'ERROR: from name and to name can\'t be the same value')
             return 1
         
-        if to_name not in current_repos:
+        if to_name in current_repos:
             print(f'ERROR: Destination name already exists in config')
-            return 1
+            return 2
 
         # Rename action
         config['repos'][to_name] = config['repos'][from_name]
diff --git a/tests/test_core.py b/tests/test_core.py
@@ -170,3 +170,25 @@ def test_repo_set(sgit):
     config = sgit._get_config_file()
     assert config['repos']['1a']['clone-url'] == '2c'
     assert config['repos']['1a']['revision'] == '2d'
+
+
+def test_repo_rename(sgit):
+    retcode = sgit.init_repo()
+    assert retcode == None
+
+    ## If source and destination repo name is the same, throw error
+    retcode = sgit.repo_rename('foobar', 'foobar')
+    assert retcode == 1
+
+    ## If destination repo name already exists then throw error
+    sgit.repo_add('qwerty', 'qwe@rty.se', 'master')
+    retcode = sgit.repo_rename('foobar', 'qwerty')
+    assert retcode == 2
+
+    sgit.repo_add('foobar', 'bar@foo.se', 'master')
+    retcode = sgit.repo_rename('foobar', 'barfoo')
+    assert retcode is None
+
+    config = sgit._get_config_file()
+    assert 'foobar' not in config['repos']
+    assert 'barfoo' in config['repos']
