fix broken unit tests by avoid triggering deprecated behaviour (unless intended)#1126
fix broken unit tests by avoid triggering deprecated behaviour (unless intended)#1126boegel merged 14 commits intoeasybuilders:developfrom
Conversation
fix issues w.r.t. logging in tests
|
Test FAILed. |
|
Tests are still failing? |
There was a problem hiding this comment.
you probably want to do this in a setup method?
and then set it back after your test is done?
There was a problem hiding this comment.
the default setUp method (see test/framework/utilities.py) sets this to 100000, so this is resetting it so the deprecated behaviour can be tested...
There was a problem hiding this comment.
The problem with it I have is that it seems to do some magic behind the scenes, but it is needed, but I don't know why.
the method name is also very non descriptive.
There was a problem hiding this comment.
method names should be all lower case
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
w00! Jenkins gives this a green light, so I'll merge this in to fix the |
fix broken unit tests by avoid triggering deprecated behaviour (unless intended)
this also includes the fixes in #1123, #1124 and #1127 which are required to make all tests pass