define __contains__ in EasyConfig class#1155
Merged
boegel merged 5 commits intoeasybuilders:developfrom Feb 4, 2015
Merged
Conversation
Member
Author
|
@wpoely86: please review? |
Member
Author
There was a problem hiding this comment.
well, there is no value, since the provided key doesn't exist...
Member
Author
There was a problem hiding this comment.
ah, this is setting, my bad
|
Test FAILed. |
|
Test PASSed. |
Member
Author
|
going in, thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Feb 4, 2015
define __contains__ in EasyConfig class
This was referenced Feb 5, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no
__contains__is defined, Python falls back to using__getitem__forkey in easyconfig_instancetype of expressions (see https://docs.python.org/2/reference/datamodel.html#object.__contains__)this patch fixes the issue that this fails hard if such an expression is used with a non-existing key
it also makes sure that a decent error message is shown whenever an undefined easyconfig parameter is used (get or set)