do not ignore exit code of failing postinstall commands#1157
Merged
boegel merged 2 commits intoeasybuilders:developfrom Feb 6, 2015
Merged
do not ignore exit code of failing postinstall commands#1157boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
Member
|
looks good! |
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
Fix is OK for this problem but when run in debug mode, the return code of |
Member
Author
|
@wpoely86: fixed the logging issue in |
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
going in, thanks @wpoely86 for the review! |
boegel
added a commit
that referenced
this pull request
Feb 6, 2015
do not ignore exit code of failing postinstall commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue uncovered by @pescobar
@wpoely86: please review?