stop including a crippled copy of vsc-base, include vsc-base as a proper dependency instead by boegel · Pull Request #1160 · easybuilders/easybuild-framework

boegel · 2015-02-07T09:55:21Z

depends on hpcugent/vsc-base#153 and a vsc-base v2.0.1 release on PyPi

@stdweird: please review

hpcugentbot · 2015-02-07T10:09:09Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1263/
Test FAILed.

wpoely86 · 2015-02-07T12:48:43Z

looks fine?

boegel · 2015-02-08T15:34:50Z

Once hpcugent/vsc-base#153 is merged in, this meeds extensive testing to see whether installing this eith easy_install and the bootstrap script still works as expected.

I hope to get this out soon, since we would have an early alpha of EasyBuild v2.0 then...

…2.0.0

hpcugentbot · 2015-02-10T07:04:04Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1275/
Test FAILed.

hpcugentbot · 2015-02-10T07:04:21Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1276/
Test FAILed.

stdweird · 2015-02-10T07:08:38Z

LGTM, but test failed
i guess you need to give jenkins the new dependency first?

boegel · 2015-02-10T07:09:01Z

Jenkins: test this please

boegel · 2015-02-10T07:10:07Z

@stdweird: yep, vsc-base is installed on Jenkins (and reinstalled whenever a vsc-base PR is merged in), but the EasyBuild framework tests did not have the location included in $PYTHONPATH yet, should be fixed now for the PR building test

boegel · 2015-02-10T07:10:43Z

@wpoely86: feel like playing around with this, e.g. testing it with easy_install and/or pip, and see if anything breaks?

hpcugentbot · 2015-02-10T07:21:16Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1277/
Test FAILed.

boegel · 2015-02-10T08:44:53Z

Jenkins: test this please

hpcugentbot · 2015-02-10T09:05:39Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1278/
Test FAILed.

boegel · 2015-02-10T09:46:48Z

Jenkins: test this please

hpcugentbot · 2015-02-10T09:58:47Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1280/
Test FAILed.

boegel · 2015-02-10T10:28:21Z

for some reason, Jenkins can't obtain a GitHub token anymore for the unit tests that require it... not sure what's going on there, will look into fixing it

boegel · 2015-02-11T00:46:55Z

Jenkins: test this please

hpcugentbot · 2015-02-11T06:39:22Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1295/
Test FAILed.

boegel · 2015-02-11T06:39:45Z

Jenkins: test this please

hpcugentbot · 2015-02-11T07:05:11Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1296/
Test PASSed.

boegel · 2015-02-11T07:21:44Z

issues with GitHub token used by Jenkins fixed via #1165

hpcugentbot · 2015-02-14T14:10:56Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1347/
Test PASSed.

wpoely86 · 2015-02-14T19:02:47Z

$ easy_install --prefix $HOME/opt https://github.com/boegel/easybuild-framework/archive/fd142036749d30e7f088e0f84eaff9cb0929ff50.tar.gz#egg=easybuild-framework
Downloading https://github.com/boegel/easybuild-framework/archive/fd142036749d30e7f088e0f84eaff9cb0929ff50.tar.gz#egg=easybuild-framework
Processing fd142036749d30e7f088e0f84eaff9cb0929ff50.tar.gz
Writing /tmp/easy_install-O9WxFg/easybuild-framework-fd142036749d30e7f088e0f84eaff9cb0929ff50/setup.cfg
Running easybuild-framework-fd142036749d30e7f088e0f84eaff9cb0929ff50/setup.py -q bdist_egg --dist-dir /tmp/easy_install-O9WxFg/easybuild-framework-fd142036749d30e7f088e0f84eaff9cb0929ff50/egg-dist-tmp-wxJ567
Installing with setuptools.setup...
Installing version 2.0.0dev (API version 2)
Removing easybuild-framework 1.16.1 from easy-install.pth file
Adding easybuild-framework 2.0.0dev to easy-install.pth file
Installing eb script to /home/ward/opt/bin
Installing minimal_bash_completion.bash script to /home/ward/opt/bin
Installing optcomplete.bash script to /home/ward/opt/bin

Installed /home/ward/opt/lib/python2.7/site-packages/easybuild_framework-2.0.0dev-py2.7.egg
Processing dependencies for easybuild-framework==2.0.0dev
Searching for vsc-base>=2.0.0
Reading https://pypi.python.org/simple/vsc-base/
Best match: vsc-base 2.0.0
Downloading https://pypi.python.org/packages/source/v/vsc-base/vsc-base-2.0.0.tar.gz#md5=2212b1312fc6d9bdaf809d0134545875
Processing vsc-base-2.0.0.tar.gz
Writing /tmp/easy_install-6erPpx/vsc-base-2.0.0/setup.cfg
Running vsc-base-2.0.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-6erPpx/vsc-base-2.0.0/egg-dist-tmp-lPWc_q
cleanup lib/vsc_base.egg-info
New target = {'maintainer': 'Stijn De Weirdt;Jens Timmermans;Andy Georges', 'name': 'vsc-base', 'author': 'Stijn De Weirdt;Jens Timmermans;Andy Georges', 'cmdclass': {'bdist_rpm': <class vsc.install.shared_setup.vsc_bdist_rpm at 0x7fbf4854d2c0>, 'egg_info': <class vsc.install.shared_setup.vsc_egg_info at 0x7fbf489d0a10>, 'install_scripts': <class vsc.install.shared_setup.vsc_install_scripts at 0x7fbf485326d0>}, 'download_url': 'https://github.com/hpcugent/vsc-base', 'maintainer_email': '[email protected];[email protected];[email protected]', 'url': 'https://github.com/hpcugent/vsc-base', 'author_email': '[email protected];[email protected];[email protected]', 'version': '2.0.0', 'scripts': ['bin/logdaemon.py', 'bin/startlogdaemon.sh', 'bin/bdist_rpm.sh', 'bin/optcomplete.bash'], 'install_requires': ['setuptools'], 'packages': ['vsc', 'vsc.utils', 'vsc.install'], 'package_dir': {'': 'lib'}}
looking for extra dist files
zip_safe flag not set; analyzing archive contents...
vsc.__init__: module references __path__
vsc.utils.missing: module references __path__
vsc.utils.generaloption: module MAY be using inspect.stack
vsc.utils.fancylogger: module MAY be using inspect.stack
Adding vsc-base 2.0.0 to easy-install.pth file
Installing bdist_rpm script to /home/ward/opt/bin
Installing startlogdaemon script to /home/ward/opt/bin
Installing logdaemon script to /home/ward/opt/bin
Installing optcomplete.bash script to /home/ward/opt/bin

Installed /home/ward/opt/lib/python2.7/site-packages/vsc_base-2.0.0-py2.7.egg
Finished processing dependencies for easybuild-framework==2.0.0dev

Seems fine?

boegel · 2015-02-14T19:13:40Z

Looks good, yeah. I'll look into making the bootstrap more flexible, so we can retest bootstrapping without actually releasing first (that's something I need to do anyway).

But since the bootstrap uses easy_install, that should be fine too.

Conflicts: setup.py

hpcugentbot · 2015-02-20T19:43:32Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1390/
Test PASSed.

boegel · 2015-02-20T20:36:25Z

enhanced bootstrap script that allows to bootstrap from provided tarballs is available in #1184, testing this branch with that script didn't reveal any problems (as expected), so I'm merging in this beast

thanks for reviewing @stdweird, @wpoely86!

stop including a crippled copy of vsc-base, include vsc-base as a proper dependency instead

boegel added 4 commits February 7, 2015 10:48

remove included (crippled) copy of vsc-base)

57de298

fix required Python version in setup.cfg

ac09dfc

include vsc-base version check in main.py

b0f7d54

include vsc-base as a proper dependency in setup.py

edab6c5

boegel mentioned this pull request Feb 7, 2015

EasyBuild 2.0 #1000

Closed

27 tasks

drop version check for vsc-base, go back to only requiring vsc-base v…

914a27e

…2.0.0

drop unused import

56cb428

remove vsc and vsc.utils from list of included packages

fd14203

Merge branch 'develop' into vsc_base_dep

a4c9ea4

Conflicts: setup.py

boegel added a commit that referenced this pull request Feb 20, 2015

Merge pull request #1160 from boegel/vsc_base_dep

b36669c

stop including a crippled copy of vsc-base, include vsc-base as a proper dependency instead

boegel merged commit b36669c into easybuilders:develop Feb 20, 2015

boegel deleted the vsc_base_dep branch February 20, 2015 20:36

This was referenced Feb 21, 2015

make unit tests more robust (REVIEW) #1167

Merged

add test to make sure vsc-base is imported from outside of framework location #1194

Merged

boegel mentioned this pull request Mar 5, 2015

install-EasyBuild-develop.sh => ImportError: No module named vsc.utils #1204

Closed

Conversation

boegel commented Feb 7, 2015

Uh oh!

hpcugentbot commented Feb 7, 2015

Uh oh!

wpoely86 commented Feb 7, 2015

Uh oh!

boegel commented Feb 8, 2015

Uh oh!

hpcugentbot commented Feb 10, 2015

Uh oh!

hpcugentbot commented Feb 10, 2015

Uh oh!

stdweird commented Feb 10, 2015

Uh oh!

boegel commented Feb 10, 2015

Uh oh!

boegel commented Feb 10, 2015

Uh oh!

boegel commented Feb 10, 2015

Uh oh!

hpcugentbot commented Feb 10, 2015

Uh oh!

boegel commented Feb 10, 2015

Uh oh!

hpcugentbot commented Feb 10, 2015

Uh oh!

boegel commented Feb 10, 2015

Uh oh!

hpcugentbot commented Feb 10, 2015

Uh oh!

boegel commented Feb 10, 2015

Uh oh!

boegel commented Feb 11, 2015

Uh oh!

hpcugentbot commented Feb 11, 2015

Uh oh!

boegel commented Feb 11, 2015

Uh oh!

hpcugentbot commented Feb 11, 2015

Uh oh!

boegel commented Feb 11, 2015

Uh oh!

hpcugentbot commented Feb 14, 2015

Uh oh!

wpoely86 commented Feb 14, 2015

Uh oh!

boegel commented Feb 14, 2015

Uh oh!

hpcugentbot commented Feb 20, 2015

Uh oh!

boegel commented Feb 20, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants