Skip to content

Fix path_matches#1163

Merged
boegel merged 3 commits intoeasybuilders:developfrom
geimer:fix_path_matches
Feb 15, 2015
Merged

Fix path_matches#1163
boegel merged 3 commits intoeasybuilders:developfrom
geimer:fix_path_matches

Conversation

@geimer
Copy link
Copy Markdown
Contributor

@geimer geimer commented Feb 10, 2015

The path_matches routine should ignore non-existing paths rather than fail hard...

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 11, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1293/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 11, 2015

would be great, but I'd love to see a dedicated unit test for this before we merged this in

are you willing to give this a shot, @geimer? let me know if you need any help

I should've asked you the same for #1164, so if you're up for it, add one for mpi_family too while you're at it (or enhance the existing ones to check for None with a non-compiler toolchain)

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 11, 2015

Ah, wait, #1164 isn't merged yet, so the unit tests for mpi_family should be added there.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 15, 2015

Jenkins: ok to test

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 15, 2015

@geimer: looks great, thanks for tackling the unit test too!

I'll merge this in if Jenkins is happy with it.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1354/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 15, 2015

Going in, thanks @geimer!

boegel added a commit that referenced this pull request Feb 15, 2015
@boegel boegel merged commit d6a1354 into easybuilders:develop Feb 15, 2015
@geimer geimer deleted the fix_path_matches branch February 15, 2015 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants