Skip to content

enhance bootstrap script to allow bootstrapping using supplied tarballs#1184

Merged
boegel merged 5 commits intoeasybuilders:developfrom
boegel:enhance_bootstrap
Feb 20, 2015
Merged

enhance bootstrap script to allow bootstrapping using supplied tarballs#1184
boegel merged 5 commits intoeasybuilders:developfrom
boegel:enhance_bootstrap

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 17, 2015

Adds support for bootstrapping from supplied tarballs, by setting $EASYBUILD_BOOTSTRAP_TARBALLS to a location where source tarballs named easybuild-framework.tar.gz, vsc-base.tar.gz etc. are provided before using the bootstrap_eb.py script.

Other enhancements:

  • allow skipping stage 0 (temporary installation of distribute which delivers easy_install) by defining $EASYBUILD_BOOTSTRAP_SKIP_STAGE0
  • enabling/disabling debug logging via $EASYBUILD_BOOTSTRAP_DEBUG

This requires easybuilders/easybuild-easyblocks#559 in order to make the installation using local tarballs to work correctly.

The 'normal' bootstrap from PyPI should be unaffected (i.e. it still works for me ;-)). Installing both with and without providing vsc-base.tar.gz works.

After playing around with this, I'm close to rewriting bootstrap_eb.py in bootstrap_eb.sh, to make it simpler and easier to read...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 17, 2015

@stdweird, @wpoely86: please review/test?

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1373/
Test PASSed.

@pforai
Copy link
Copy Markdown
Contributor

pforai commented Feb 17, 2015

Works like a charm for me on MacOS 10.10.2!

Comment thread easybuild/scripts/bootstrap_eb.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the http to httpS for all URLs?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent suggestion, thanks!

Comment thread easybuild/scripts/bootstrap_eb.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check if this is false if EASYBUILD_BOOTSTRAP_DEBUG=0?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, no, it's not, since the 0 is taken as a string value, and a non-empty string is equivalent to True

not sure how to tackle this one...

but since this is disabled by default, it's probably not a disaster if setting this to 0 enables it?

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1377/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 18, 2015

@stdweird: remarks fixed, good to go in?

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1380/
Test PASSed.

@stdweird
Copy link
Copy Markdown
Contributor

also, can you show me the link to the diocs that explain this new functionality?

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1389/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 20, 2015

updated docs: easybuilders/easybuild#87

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 20, 2015

updated docs merged, so this is going in too, thanks for the review @stdweird, and @pforai for retesting the bootstrap script!

boegel added a commit that referenced this pull request Feb 20, 2015
enhance bootstrap script to allow bootstrapping using supplied tarballs
@boegel boegel merged commit a48b596 into easybuilders:develop Feb 20, 2015
@boegel boegel deleted the enhance_bootstrap branch February 20, 2015 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants