drop custom setUp/tearDown in toolchain tests which are hard modifying $MODULEPATH#1191
Merged
boegel merged 1 commit intoeasybuilders:developfrom Feb 26, 2015
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
only affects the (toolchain) tests, and only removal of code, so nothing much to review thanks again for the help in figuring this out @ocaisa! |
boegel
added a commit
that referenced
this pull request
Feb 26, 2015
…ardown drop custom setUp/tearDown in toolchain tests which are hard modifying $MODULEPATH
boegel
added a commit
to boegel/easybuild-framework
that referenced
this pull request
Feb 27, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolchain unit tests hard modifying
$MODULEPATHcaused some issues with these tests on a system where onlymodulecmd.tclwas available; the tests seemed to get stuck in an infinite loop.Simply dropping the custom
setUpandtearDownintest/framework/toolchain.pyfixes the issues, since (re)setting$MODULEPATHis already properly done intest/framework/utilities.py.Thanks to @ocaisa to help figure this out.