Skip to content

fix install-EasyBuild-develop.sh script w.r.t. vsc-base dependency#1193

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_install_develop_script
Mar 2, 2015
Merged

fix install-EasyBuild-develop.sh script w.r.t. vsc-base dependency#1193
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_install_develop_script

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 27, 2015

@besserox: please review?

@boegel boegel mentioned this pull request Feb 27, 2015
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2015

Hmm, need to look into this:

=== Cloning boegel/easybuild-easyconfigs ...
...
=== Checking out the 'develop' branch
fatal: A branch named 'develop' already exists.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Feb 27, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1436/
Test PASSed.

@besserox
Copy link
Copy Markdown
Contributor

besserox commented Mar 1, 2015

I tried the new version of the script. I forked the vsc repository on github account and the installation was fine. Then when I tried to run EasyBuild, I get the following error:

$ eb -h
Traceback (most recent call last):
  File "/home/xavier/tmp/eb/install/easybuild-framework/easybuild/main.py", line 45, in <module>
    from easybuild.tools.build_log import EasyBuildError, init_logging, print_msg, print_error, stop_logging
  File "/home/xavier/tmp/eb/install/easybuild-framework/easybuild/tools/build_log.py", line 38, in <module>
    from vsc.utils import fancylogger
ImportError: No module named vsc.utils

$ echo $PYTHONPATH
/home/xavier/tmp/eb/install/easybuild-easyconfigs:/home/xavier/tmp/eb/install/easybuild-easyblocks:/home/xavier/tmp/eb/install/easybuild-framework:/home/xavier/tmp/eb/install/vsc-base

If I use $root/vsc-base/lib instead of $root/vsc-base in my PYTHONPATH, it seems to work.

besserox
besserox reviewed Mar 1, 2015
View reviewed changes
Comment thread easybuild/scripts/install-EasyBuild-develop.sh Outdated
Copy link
Copy Markdown
Contributor

@besserox besserox Mar 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it should be prepend-path PYTHONPATH "\$root/vsc-base/lib" here.

Copy link
Copy Markdown
Member Author

@boegel boegel Mar 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, will fix.

I was still testing the updated script myself as well, but bumped into another issue (that I still need to figure out).

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 2, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1441/
Test PASSed.

@besserox
Copy link
Copy Markdown
Contributor

besserox commented Mar 2, 2015

It looks good to me now. I tested and it works fine.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 2, 2015

@besserox: thanks for the feedback!

boegel added a commit that referenced this pull request Mar 2, 2015
@boegel
Merge pull request #1193 from boegel/fix_install_develop_script
7a29504 
fix install-EasyBuild-develop.sh script w.r.t. vsc-base dependency
@boegel boegel merged commit 7a29504 into easybuilders:develop Mar 2, 2015
@boegel boegel deleted the fix_install_develop_script branch March 2, 2015 16:25
@boegel boegel mentioned this pull request Mar 11, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @besserox