remove fetch_parameter_from_easyconfig_file rather than deprecating it#1206
Merged
boegel merged 1 commit intoeasybuilders:developfrom Mar 5, 2015
Merged
Conversation
…t, since it's internal to the EasyBuild framework
Member
|
looks fine |
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
Thanks @wpoely86! |
boegel
added a commit
that referenced
this pull request
Mar 5, 2015
…config_file remove fetch_parameter_from_easyconfig_file rather than deprecating it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need to deprecate something if it's internal to the framework (i.e., not meant to be used in easyblocks), since that means dragging it along (and documenting it) for quite some time to come...
@wpoely86: please review?