Use communicate instead of wait

jamesls · jamesls · commit 8a90fcec59cd · 2013-09-16T13:46:36.000-07:00
To fix the script from hanging.
diff --git a/scripts/make-bundle b/scripts/make-bundle
@@ -55,11 +55,12 @@ def run(cmd):
     sys.stdout.write("Running cmd: %s\n" % cmd)
     p = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE,
                          stderr=subprocess.PIPE)
+    stdout, stderr = p.communicate()
     rc = p.wait()
-    if rc != 0:
+    if p.returncode != 0:
         raise BadRCError("Bad rc (%s) for cmd '%s': %s" % (
-            rc, cmd, p.stderr.read() + p.stdout.read()))
-    return p.stdout.read()
+            rc, cmd, stderr + stdout))
+    return stdout
 
 
 def create_scratch_dir():
