Skip to content

Commit f9f0f81

Browse files
manuqmanuq
authored
Merge pull request #13 from endlessm/enable-crashlytics-native-symbol-upload
Add flag to enable processing and uploading of native symbols to Firebase servers.
2 parents 934cf66 + 987ff07 commit f9f0f81

3 files changed

Lines changed: 14 additions & 0 deletions

File tree

‎doc/source/buildoptions.rst‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,9 @@ options (this list may not be exhaustive):
9696
project directory.
9797
- ``--add-gradle-plugins``: Add a plugin for gradle. The format of the option
9898
is ``<plugin-id>:<classpath>``. The option can be specified multiple times.
99+
- ``--enable-crashlytics-native-symbol-upload``: Enable processing and uploading
100+
of native symbols to Firebase servers. This flag must be enabled to see
101+
properly-symbolicated native stack traces in the Crashlytics dashboard.
99102

100103

101104
webview
@@ -162,6 +165,9 @@ ready.
162165
project directory.
163166
- ``--add-gradle-plugins``: Add a plugin for gradle. The format of the option
164167
is ``<plugin-id>:<classpath>``. The option can be specified multiple times.
168+
- ``--enable-crashlytics-native-symbol-upload``: Enable processing and uploading
169+
of native symbols to Firebase servers. This flag must be enabled to see
170+
properly-symbolicated native stack traces in the Crashlytics dashboard.
165171

166172

167173
service_library

‎pythonforandroid/bootstraps/common/build/build.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -889,6 +889,9 @@ def parse_args_and_make_package(args=None):
889889
ap.add_argument('--google-services-json', dest='google_services_json',
890890
default='google-services.json',
891891
help='Path to google-services.json file')
892+
ap.add_argument('--enable-crashlytics-native-symbol-upload', dest='enable_crashlytics_native_symbol_upload',
893+
action='store-true',
894+
help='Enable processing and uploading of native symbols to Firebase servers.')
892895

893896
# Put together arguments, and add those from .p4a config file:
894897
if args is None:

‎pythonforandroid/bootstraps/common/build/templates/build.tmpl.gradle‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,11 @@ android {
9292
{% if args.sign -%}
9393
signingConfig signingConfigs.release
9494
{%- endif %}
95+
{$ if args.enable_crashlytics_native_symbol_upload -%}
96+
firebaseCrashlytics {
97+
nativeSymbolUploadEnabled true
98+
}
99+
{%- endif %}
95100
}
96101
}
97102

0 commit comments

Comments
 (0)