Fixes rebase conflict and unit tests

AndreMiras · AndreMiras · commit bec18e13f7fe · 2018-12-14T23:16:06.000+01:00
diff --git a/pythonforandroid/distribution.py b/pythonforandroid/distribution.py
@@ -2,7 +2,7 @@
 import glob
 import json
 
-from pythonforandroid.logger import (info, info_notify, Err_Style, Err_Fore)
+from pythonforandroid.logger import (info, info_notify, warning, Err_Style, Err_Fore)
 from pythonforandroid.util import current_directory, BuildInterruptingException
 from shutil import rmtree
 
@@ -130,21 +130,7 @@ def get_distribution(cls, ctx, name=None, recipes=[],
         # If there was a name match but we didn't already choose it,
         # then the existing dist is incompatible with the requested
         # configuration and the build cannot continue
-<<<<<<< HEAD
         if name_match_dist is not None and not allow_replace_dist:
-            error('Asked for dist with name {name} with recipes ({req_recipes}) and '
-                  'NDK API {req_ndk_api}, but a dist '
-                  'with this name already exists and has either incompatible recipes '
-                  '({dist_recipes}) or NDK API {dist_ndk_api}'.format(
-                      name=name,
-                      req_ndk_api=ndk_api,
-                      dist_ndk_api=name_match_dist.ndk_api,
-                      req_recipes=', '.join(recipes),
-                      dist_recipes=', '.join(name_match_dist.recipes)))
-            error('No compatible dist found, so exiting.')
-            exit(1)
-=======
-        if name_match_dist is not None:
             raise BuildInterruptingException(
                 'Asked for dist with name {name} with recipes ({req_recipes}) and '
                 'NDK API {req_ndk_api}, but a dist '
@@ -155,7 +141,6 @@ def get_distribution(cls, ctx, name=None, recipes=[],
                     dist_ndk_api=name_match_dist.ndk_api,
                     req_recipes=', '.join(recipes),
                     dist_recipes=', '.join(name_match_dist.recipes)))
->>>>>>> Replaced many exit(1)s with exceptions
 
         # If we got this far, we need to build a new dist
         dist = Distribution(ctx)
diff --git a/tests/test_graph.py b/tests/test_graph.py
@@ -1,6 +1,7 @@
 from pythonforandroid.build import Context
 from pythonforandroid.graph import get_recipe_order_and_bootstrap
 from pythonforandroid.bootstrap import Bootstrap
+from pythonforandroid.util import BuildInterruptingException
 from itertools import product
 
 import pytest
@@ -27,8 +28,12 @@ def test_valid_recipe_order_and_bootstrap(names, bootstrap):
 
 @pytest.mark.parametrize('names,bootstrap', invalid_combinations)
 def test_invalid_recipe_order_and_bootstrap(names, bootstrap):
-    with pytest.raises(SystemExit):
+    with pytest.raises(BuildInterruptingException) as e_info:
         get_recipe_order_and_bootstrap(ctx, names, bootstrap)
+    assert e_info.value.message == (
+        "Didn't find any valid dependency graphs. "
+        "This means that some of your requirements pull in conflicting dependencies."
+    )
 
 
 def test_bootstrap_dependency_addition():
