fix: Using version args to install the correct feast version#3953
Merged
shuchu merged 2 commits intofeast-dev:masterfrom Feb 20, 2024
Merged
fix: Using version args to install the correct feast version#3953shuchu merged 2 commits intofeast-dev:masterfrom
shuchu merged 2 commits intofeast-dev:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feature_servers/multicloud does not use
mastersources to install feast in image. It uses pypi'sfeastlatest version.Even though the github publish action has a
needsonpublish-python-sdkbefore running the publish step, pypi cache might not be updated causing an older feast sdk version to be installed.Refer to #3915 where,
$ docker run -it --rm feastdev/feature-server:0.35.0 pip show feast | grep Version Version: 0.34.1Which issue(s) this PR fixes:
Fixes #3915