From f602f6c55e28c73a26b20b9509e14a2c7ce84c47 Mon Sep 17 00:00:00 2001
From: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
Date: Tue, 16 Aug 2022 16:34:44 -0700
Subject: [PATCH 1/4] Update sql.py

Fix a bug that `name = name or obj.name if hasattr(obj, "name") else None` has wrong order sequence.

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
---
 sdk/python/feast/infra/registry/sql.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sdk/python/feast/infra/registry/sql.py b/sdk/python/feast/infra/registry/sql.py
index 55412b33be3..7867cdff4c3 100644
--- a/sdk/python/feast/infra/registry/sql.py
+++ b/sdk/python/feast/infra/registry/sql.py
@@ -695,7 +695,7 @@ def _apply_object(
     ):
         self._maybe_init_project_metadata(project)
 
-        name = name or obj.name if hasattr(obj, "name") else None
+        name = name or (obj.name if hasattr(obj, "name") else None)
         assert name, f"name needs to be provided for {obj}"
 
         with self.engine.connect() as conn:

From 513e16a5d2a4b7f737250080f2effaccbc9f29fb Mon Sep 17 00:00:00 2001
From: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
Date: Wed, 17 Aug 2022 09:32:10 -0700
Subject: [PATCH 2/4] add test

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
---
 sdk/python/tests/unit/test_sql_registry.py | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/sdk/python/tests/unit/test_sql_registry.py b/sdk/python/tests/unit/test_sql_registry.py
index c1b45848ce5..cf5579b8c24 100644
--- a/sdk/python/tests/unit/test_sql_registry.py
+++ b/sdk/python/tests/unit/test_sql_registry.py
@@ -551,3 +551,24 @@ def test_apply_data_source(sql_registry):
     assert registry_batch_source == batch_source
 
     sql_registry.teardown()
+
+@pytest.mark.skipif(
+    sys.platform == "darwin" and "GITHUB_REF" in os.environ,
+    reason="does not run on mac github actions",
+)
+@pytest.mark.parametrize(
+    "sql_registry",
+    [
+        lazy_fixture("mysql_registry"),
+        lazy_fixture("pg_registry"),
+        lazy_fixture("sqlite_registry"),
+    ],
+)
+def test_update_infra(sql_registry):
+    # Create infra object
+    project = "project"
+    infra = sql_registry.get_infra(project=project)
+
+    # Should succuessfully run update infra
+    sql_registry.update_infra(infra, project)
+    sql_registry.teardown()

From 9cf3f05ab262762a64160636399cca4d6c469567 Mon Sep 17 00:00:00 2001
From: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
Date: Wed, 17 Aug 2022 09:33:13 -0700
Subject: [PATCH 3/4] add test

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
---
 sdk/python/tests/unit/test_sql_registry.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sdk/python/tests/unit/test_sql_registry.py b/sdk/python/tests/unit/test_sql_registry.py
index cf5579b8c24..f620db8cea6 100644
--- a/sdk/python/tests/unit/test_sql_registry.py
+++ b/sdk/python/tests/unit/test_sql_registry.py
@@ -569,6 +569,6 @@ def test_update_infra(sql_registry):
     project = "project"
     infra = sql_registry.get_infra(project=project)
 
-    # Should succuessfully run update infra
+    # Should run update infra successfully
     sql_registry.update_infra(infra, project)
     sql_registry.teardown()

From d3ae960c0ed83153f7b574f1db462cd868edec7b Mon Sep 17 00:00:00 2001
From: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
Date: Wed, 17 Aug 2022 09:57:56 -0700
Subject: [PATCH 4/4] fix lint

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
---
 sdk/python/tests/unit/test_sql_registry.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sdk/python/tests/unit/test_sql_registry.py b/sdk/python/tests/unit/test_sql_registry.py
index f620db8cea6..877811d0f32 100644
--- a/sdk/python/tests/unit/test_sql_registry.py
+++ b/sdk/python/tests/unit/test_sql_registry.py
@@ -552,6 +552,7 @@ def test_apply_data_source(sql_registry):
 
     sql_registry.teardown()
 
+
 @pytest.mark.skipif(
     sys.platform == "darwin" and "GITHUB_REF" in os.environ,
     reason="does not run on mac github actions",