Merge pull request #275 from Oblivionsage/fix/unsigned-tx-amount-underflow

tobtoht · web-flow · commit 230158896c2e · 2025-11-13T09:36:00.000Z
fix: prevent integer underflow in amount() bounds check
diff --git a/src/libwalletqt/UnsignedTransaction.cpp b/src/libwalletqt/UnsignedTransaction.cpp
@@ -19,7 +19,7 @@ QString UnsignedTransaction::errorString() const
 quint64 UnsignedTransaction::amount(size_t index) const
 {
     std::vector<uint64_t> arr = m_pimpl->amount();
-    if(index > arr.size() - 1)
+    if(arr.empty() || index >= arr.size())
         return 0;
     return arr[index];
 }

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ QString UnsignedTransaction::errorString() const`
`19`	`19`	`quint64 UnsignedTransaction::amount(size_t index) const`
`20`	`20`	`{`
`21`	`21`	`std::vector<uint64_t> arr = m_pimpl->amount();`
`22`		`- if(index > arr.size() - 1)`
	`22`	`+ if(arr.empty() \|\| index >= arr.size())`
`23`	`23`	`return 0;`
`24`	`24`	`return arr[index];`
`25`	`25`	`}`