Remove multibroadcast

tobtoht · tobtoht · commit 68b75abf013d · 2025-06-04T15:29:29.000+02:00
diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
@@ -443,8 +443,6 @@ void MainWindow::initWalletContext() {
     connect(m_wallet, &Wallet::donationSent,        this, []{
         conf()->set(Config::donateBeg, -1);
     });
-    
-    connect(m_wallet, &Wallet::multiBroadcast,      this, &MainWindow::onMultiBroadcast);
 }
 
 void MainWindow::menuToggleTabVisible(const QString &key){
@@ -642,19 +640,6 @@ void MainWindow::onSubtractFeeFromAmountEnabled(bool enabled) {
     m_sendWidget->setSubtractFeeFromAmountEnabled(enabled);
 }
 
-void MainWindow::onMultiBroadcast(const QMap<QString, QString> &txHexMap) {
-    QMapIterator<QString, QString> i(txHexMap);
-    while (i.hasNext()) {
-        i.next();
-        for (const auto& node: m_nodes->nodes()) {
-            QString address = node.toURL();
-            qDebug() << QString("Relaying %1 to: %2").arg(i.key(), address);
-            m_rpc->setDaemonAddress(address);
-            m_rpc->sendRawTransaction(i.value());
-        }
-    }
-}
-
 void MainWindow::onSyncStatus(quint64 height, quint64 target, bool daemonSync) {
     if (height >= (target - 1)) {
         this->updateNetStats();
diff --git a/src/MainWindow.h b/src/MainWindow.h
@@ -171,7 +171,6 @@ private slots:
     void onOfflineMode(bool offline);
     void onManualFeeSelectionEnabled(bool enabled);
     void onSubtractFeeFromAmountEnabled(bool enabled);
-    void onMultiBroadcast(const QMap<QString, QString> &txHexMap);
 
 private:
     friend WindowManager;
diff --git a/src/SettingsDialog.cpp b/src/SettingsDialog.cpp
@@ -318,15 +318,6 @@ void Settings::setupMemoryTab() {
 }
 
 void Settings::setupTransactionsTab() {
-    // [Multibroadcast outgoing transactions]
-    ui->checkBox_multibroadcast->setChecked(conf()->get(Config::multiBroadcast).toBool());
-    connect(ui->checkBox_multibroadcast, &QCheckBox::toggled, [](bool toggled){
-        conf()->set(Config::multiBroadcast, toggled);
-    });
-    connect(ui->btn_multibroadcast, &QPushButton::clicked, [this]{
-        Utils::showInfo(this, "Multibroadcasting", "Multibroadcasting relays outgoing transactions to all nodes in your node list. This may improve transaction relay speed and reduces the chance of your transaction failing.");
-    });
-
     // Hide unimplemented settings
     ui->checkBox_alwaysOpenAdvancedTxDialog->hide();
     ui->checkBox_requirePasswordToSpend->hide();
diff --git a/src/libwalletqt/Wallet.cpp b/src/libwalletqt/Wallet.cpp
@@ -1008,13 +1008,6 @@ void Wallet::onTransactionCommitted(bool success, PendingTransaction *tx, const
         return;
     }
 
-    // Nodes - even well-connected, properly configured ones - consistently fail to relay transactions
-    // To mitigate transactions failing we just send the transaction to every node we know about over Tor
-    if (conf()->get(Config::multiBroadcast).toBool()) {
-        // Let MainWindow handle this
-        emit multiBroadcast(txHexMap);
-    }
-
     // this tx was a donation to Feather, stop our nagging
     if (this->donationSending) {
         this->donationSending = false;
diff --git a/src/libwalletqt/Wallet.h b/src/libwalletqt/Wallet.h
@@ -470,7 +470,6 @@ Q_OBJECT
 
     void selectedInputsChanged(const QStringList &selectedInputs);
 
-    void multiBroadcast(const QMap<QString, QString> &txHexMap);
     void heightsRefreshed(bool success, quint64 daemonHeight, quint64 targetHeight);
 
 private:
diff --git a/src/utils/config.cpp b/src/utils/config.cpp
@@ -79,7 +79,7 @@ static const QHash<Config::ConfigKey, ConfigDirective> configStrings = {
         {Config::offlineMode, {QS("offlineMode"), false}},
 
         // Transactions
-        {Config::multiBroadcast, {QS("multiBroadcast"), true}},
+        {Config::multiBroadcast, {QS("multiBroadcast"), false}},
         {Config::offlineTxSigningMethod, {QS("offlineTxSigningMethod"), Config::OTSMethod::UnifiedResources}},
         {Config::offlineTxSigningForceKISync, {QS("offlineTxSigningForceKISync"), false}},
         {Config::manualFeeTierSelection, {QS("manualFeeTierSelection"), false}},
