Add types to Random class

bohwaz · bohwaz · commit 4d75651e9c74 · 2024-08-25T02:32:34.000+02:00
diff --git a/featherbb/Core/Random.php b/featherbb/Core/Random.php
@@ -14,15 +14,15 @@ class Random
     //
     // Compute a hash of $str
     //
-    public static function hash($str)
+    public static function hash(string $str): string
     {
         return sha1($str);
     }
 
     //
     // Generate a random key of length $len
     //
-    public static function key($len, $readable = false, $hash = false)
+    public static function key(int $len, bool $readable = false, bool $hash = false): string
     {
         $key = self::secureRandomBytes($len);
 
@@ -46,7 +46,7 @@ public static function key($len, $readable = false, $hash = false)
     // Generate a random password of length $len
     // Compatibility wrapper for random_key
     //
-    public static function pass($len)
+    public static function pass(int $len): string
     {
         return self::key($len, true);
     }

Original file line number	Diff line number	Diff line change
`@@ -14,15 +14,15 @@ class Random`
`14`	`14`	`//`
`15`	`15`	`// Compute a hash of $str`
`16`	`16`	`//`
`17`		`- public static function hash($str)`
	`17`	`+ public static function hash(string $str): string`
`18`	`18`	`{`
`19`	`19`	`return sha1($str);`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`//`
`23`	`23`	`// Generate a random key of length $len`
`24`	`24`	`//`
`25`		`- public static function key($len, $readable = false, $hash = false)`
	`25`	`+ public static function key(int $len, bool $readable = false, bool $hash = false): string`
`26`	`26`	`{`
`27`	`27`	`$key = self::secureRandomBytes($len);`
`28`	`28`
`@@ -46,7 +46,7 @@ public static function key($len, $readable = false, $hash = false)`
`46`	`46`	`// Generate a random password of length $len`
`47`	`47`	`// Compatibility wrapper for random_key`
`48`	`48`	`//`
`49`		`- public static function pass($len)`
	`49`	`+ public static function pass(int $len): string`
`50`	`50`	`{`
`51`	`51`	`return self::key($len, true);`
`52`	`52`	`}`