Remove "unset $args['id']" warning in view when creating a user group

beaver-dev · beaver-dev · commit 7a7c400c4890 · 2016-04-09T17:14:34.000+02:00
diff --git a/featherbb/Controller/Admin/Groups.php b/featherbb/Controller/Admin/Groups.php
@@ -107,15 +107,16 @@ public function addedit($req, $res, $args)
 
             AdminUtils::generateAdminMenu('groups');
 
-            $group = $this->model->info_add_group($groups, $args['id']);
+            $id = isset($args['id']) ? intval($args['id']) : intval(Input::post('base_group'));
+            $group = $this->model->info_add_group($groups, $id);
 
             View::setPageInfo(array(
                     'title' => array(Utils::escape(ForumSettings::get('o_board_title')), __('Admin'), __('User groups')),
                     'active_page' => 'admin',
                     'admin_console' => true,
                     'group'    =>    $group,
                     'groups'    =>    $groups,
-                    'id'    => $args['id'],
+                    'id'    => $id,
                     'group_list'    => $this->model->get_group_list($groups, $group),
                 )
             )->addTemplate('admin/groups/add_edit_group.php')->display();
diff --git a/featherbb/Model/Admin/Groups.php b/featherbb/Model/Admin/Groups.php
@@ -36,9 +36,9 @@ public function info_add_group($groups, $id)
         $group = array();
 
         if (Input::post('add_group')) {
-            $group['base_group'] = intval(Input::post('base_group'));
+            $group['base_group'] = $id; // Equals intval(Input::post('base_group'))
             $group['base_group'] = Container::get('hooks')->fire('model.admin.groups.add_user_group', $group['base_group']);
-            $group['info'] = $groups[$group['base_group']];
+            $group['info'] = $groups[$id];
 
             $group['mode'] = 'add';
         } else {
