Handling ruleset limit exceeded error (#636)

hiranya911 · web-flow · commit aebf47f6274d · 2019-09-04T13:41:37.000-07:00
diff --git a/src/security-rules/security-rules-api-client.ts b/src/security-rules/security-rules-api-client.ts
@@ -250,6 +250,7 @@ interface Error {
 const ERROR_CODE_MAPPING: {[key: string]: SecurityRulesErrorCode} = {
   INVALID_ARGUMENT: 'invalid-argument',
   NOT_FOUND: 'not-found',
+  RESOURCE_EXHAUSTED: 'resource-exhausted',
   UNAUTHENTICATED: 'authentication-error',
   UNKNOWN: 'unknown-error',
 };
diff --git a/src/security-rules/security-rules-utils.ts b/src/security-rules/security-rules-utils.ts
@@ -23,6 +23,7 @@ export type SecurityRulesErrorCode =
   | 'invalid-argument'
   | 'invalid-server-response'
   | 'not-found'
+  | 'resource-exhausted'
   | 'service-unavailable'
   | 'unknown-error';
 
diff --git a/test/unit/security-rules/security-rules-api-client.spec.ts b/test/unit/security-rules/security-rules-api-client.spec.ts
@@ -214,6 +214,23 @@ describe('SecurityRulesApiClient', () => {
         .should.eventually.be.rejected.and.deep.equal(expected);
     });
 
+    it('should throw when the rulesets limit reached', () => {
+      const resourceExhaustedError = {
+        error: {
+          code: 429,
+          message: 'The maximum number of Rulesets (2500) have already been created for the project.',
+          status: 'RESOURCE_EXHAUSTED',
+        },
+      };
+      const stub = sinon
+        .stub(HttpClient.prototype, 'send')
+        .rejects(utils.errorFrom(resourceExhaustedError, 429));
+      stubs.push(stub);
+      const expected = new FirebaseSecurityRulesError('resource-exhausted', resourceExhaustedError.error.message);
+      return apiClient.createRuleset(RULES_CONTENT)
+        .should.eventually.be.rejected.and.deep.equal(expected);
+    });
+
     it('should throw unknown-error when error code is not present', () => {
       const stub = sinon
         .stub(HttpClient.prototype, 'send')
