Enhance getusedcoinstagstxhashes to handle edge cases (#1775)

levonpetrosyan93 · cursoragent · web-flow · commit ccaf130b91c7 · 2026-02-12T23:03:36.000+08:00
* Enhance getusedcoinstagstxhashes to handle edge cases

Added a check to ensure that the startNumber does not exceed the available elements in the tags vector. This prevents potential out-of-bounds access and improves the robustness of the function.

* Handle negative startNumber for tags tx hashes

Co-authored-by: levonpetrosyan93 &lt;levonpetrosyan93@users.noreply.github.com&gt;

---------

Co-authored-by: Cursor Agent &lt;cursoragent@cursor.com&gt;
Co-authored-by: levonpetrosyan93 &lt;levonpetrosyan93@users.noreply.github.com&gt;
diff --git a/src/rpc/misc.cpp b/src/rpc/misc.cpp
@@ -1598,11 +1598,18 @@ UniValue getusedcoinstagstxhashes(const JSONRPCRequest& request)
         tags = sparkState->GetSpendsMobile();
         ltagTxhash = sparkState->GetSpendTxIds();
     }
+
+    // Handle edge cases: negative startNumber or too large.
+    size_t skip = 0;
+    if (startNumber > 0) {
+        skip = static_cast<size_t>(startNumber);
+        if (skip > tags.size()) {
+            skip = tags.size();
+        }
+    }
+
     UniValue serializedTagsTxIds(UniValue::VARR);
-    int i = 0;
-    for ( auto it = tags.begin(); it != tags.end(); ++it, ++i) {
-        if (cmp::less((tags.size() - i - 1), startNumber))
-            continue;
+    for (auto it = tags.begin() + skip; it != tags.end(); ++it) {
         std::vector<unsigned char> serialized;
         serialized.resize(34);
         it->first.serialize(serialized.data());
