-
Notifications
You must be signed in to change notification settings - Fork 30.2k
[Regression] CupertinoActionSheetAction is no longer compatible with GestureDetector #150980
Copy link
Copy link
Closed
Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowf: cupertinoflutter/packages/flutter/cupertino repositoryflutter/packages/flutter/cupertino repositoryf: gesturesflutter/packages/flutter/gestures repository.flutter/packages/flutter/gestures repository.found in release: 3.23Found to occur in 3.23Found to occur in 3.23frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onteam-designOwned by Design Languages teamOwned by Design Languages teamtriaged-designTriaged by Design Languages teamTriaged by Design Languages teamwaiting for PR to land (fixed)A fix is in flightA fix is in flight
Description
Steps to reproduce
When addressing #150769, @delfme raised this as a second issue. I create this as a separate issue for better tracking.
- Create a sheet action named
CustomBottomSheetActionwhich implements CupertinoActionSheetAction. Inside this build body, wrap child with aGestureDetector. - Use it inside CupertinoActionSheet and see that action can't be clicked
I think this is related to #149471.
Expected results
The custom action can be clicked as before (it is working on stable channel). Only experience this on Flutter master channel.
Actual results
The custom action can't be clicked
Code sample
Code sample
import 'package:flutter/cupertino.dart';
/// Flutter code sample for [CupertinoActionSheet].
void main() => runApp(const ActionSheetApp());
class ActionSheetApp extends StatelessWidget {
const ActionSheetApp({super.key});
@override
Widget build(BuildContext context) {
return const CupertinoApp(
home: ActionSheetExample(),
);
}
}
class ActionSheetExample extends StatelessWidget {
const ActionSheetExample({super.key});
// This shows a CupertinoModalPopup which hosts a CupertinoActionSheet.
void _showActionSheet(BuildContext context) {
showCupertinoModalPopup<void>(
context: context,
builder: (BuildContext context) => CupertinoActionSheet(
title: const Text('Title'),
message: const Text('Message'),
actions: <CupertinoActionSheetAction>[
CupertinoActionSheetAction(
/// This parameter indicates the action would be a default
/// default behavior, turns the action's text to bold text.
isDefaultAction: true,
onPressed: () {
Navigator.pop(context);
},
child: const Text('Default Action'),
),
CupertinoActionSheetAction(
onPressed: () {
Navigator.pop(context);
},
child: const Text('Action'),
),
CustomBottomSheetAction(
/// This parameter indicates the action would perform
/// a destructive action such as delete or exit and turns
/// the action's text color to red.
isDestructiveAction: true,
onPressed: () {
Navigator.pop(context);
},
child: const Text('Destructive Action'),
),
],
cancelButton: CustomBottomSheetAction(
onPressed: () {
print('Cancel');
Navigator.pop(context);
},
child: const Text('Cancel'),
),
),
);
}
@override
Widget build(BuildContext context) {
return CupertinoPageScaffold(
navigationBar: const CupertinoNavigationBar(
middle: Text('CupertinoActionSheet Sample'),
),
child: Center(
child: CupertinoButton(
onPressed: () => _showActionSheet(context),
child: const Text('CupertinoActionSheet'),
),
),
);
}
}
class CustomBottomSheetAction extends StatefulWidget implements CupertinoActionSheetAction {
const CustomBottomSheetAction({
super.key,
required this.onPressed,
this.isDefaultAction = false,
this.isDestructiveAction = false,
required this.child,
});
@override
final VoidCallback onPressed;
@override
final bool isDefaultAction;
@override
final bool isDestructiveAction;
@override
final Widget child;
@override
State<CustomBottomSheetAction> createState() => _CustomBottomSheetActionState();
}
class _CustomBottomSheetActionState extends State<CustomBottomSheetAction> {
@override
Widget build(BuildContext context) {
TextStyle style = const TextStyle(fontSize: 16);
return GestureDetector(
onTap: widget.onPressed,
behavior: HitTestBehavior.opaque,
child: ConstrainedBox(
constraints: const BoxConstraints(minHeight: 57),
child: Container(
alignment: AlignmentDirectional.center,
padding: const EdgeInsets.symmetric(
vertical: 16.0,
horizontal: 10.0,
),
decoration: BoxDecoration(
borderRadius: BorderRadius.circular(widget.isDefaultAction ? 12 : 0),
),
child: DefaultTextStyle(
style: style,
textAlign: TextAlign.center,
child: widget.child,
),
),
),
);
}
}
Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
[Paste your logs here]Flutter Doctor output
Doctor output
[!] Flutter (Channel master, 3.23.0-13.0.pre.370, on macOS 14.1 23B74 darwin-x64, locale en-VN)
• Flutter version 3.23.0-13.0.pre.370 on channel master at /Users/huynq/Documents/GitHub/flutter_master
! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision eb58fe16b6 (70 minutes ago), 2024-06-28 07:36:03 +0100
• Engine revision a78f5ce743
• Dart version 3.5.0 (build 3.5.0-311.0.dev)
• DevTools version 2.36.0
• If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/huynq/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/huynq/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
• Xcode at /Applications/Xcode15.4.app/Contents/Developer
• Build 15F31d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• android-studio-dir = /Applications/Android Studio.app/
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
[✓] VS Code (version 1.90.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.90.0
[✓] Connected device (3 available)
• iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios • iOS 15.8 19H370
• macOS (desktop) • macos • darwin-x64 • macOS 14.1 23B74 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 126.0.6478.127
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowf: cupertinoflutter/packages/flutter/cupertino repositoryflutter/packages/flutter/cupertino repositoryf: gesturesflutter/packages/flutter/gestures repository.flutter/packages/flutter/gestures repository.found in release: 3.23Found to occur in 3.23Found to occur in 3.23frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onteam-designOwned by Design Languages teamOwned by Design Languages teamtriaged-designTriaged by Design Languages teamTriaged by Design Languages teamwaiting for PR to land (fixed)A fix is in flightA fix is in flight