Address review comments

cbenhagen · cbenhagen · commit 29b98a86a7c5 · 2019-12-01T15:26:40.000+01:00
diff --git a/packages/video_player/video_player_web/CHANGELOG.md b/packages/video_player/video_player_web/CHANGELOG.md
@@ -1,3 +1,3 @@
-## 0.0.1
+## 0.1.0
 
 * Initial release
diff --git a/packages/video_player/video_player_web/lib/video_player_web.dart b/packages/video_player/video_player_web/lib/video_player_web.dart
@@ -33,8 +33,8 @@ class VideoPlayerPlugin extends VideoPlayerPlatform {
   }
 
   void _disposeAllPlayers() {
-    _videoPlayers
-        .forEach((_, _VideoPlayer videoPlayer) => videoPlayer.dispose());
+    _videoPlayers.values
+        .forEach((_VideoPlayer videoPlayer) => videoPlayer.dispose());
     _videoPlayers.clear();
   }
 
@@ -114,9 +114,10 @@ class _VideoPlayer {
       ..controls = false
       ..style.border = 'none';
 
+    // TODO(hterkelsen): Use initialization parameters once they are available
     // ignore: undefined_prefixed_name
     ui.platformViewRegistry.registerViewFactory(
-        textureId.toString(), (int viewId) => videoElement);
+        'videoPlayer-$textureId', (int viewId) => videoElement);
 
     videoElement.onCanPlay.listen((dynamic _) {
       if (!isInitialized) {
diff --git a/packages/video_player/video_player_web/pubspec.yaml b/packages/video_player/video_player_web/pubspec.yaml
@@ -2,7 +2,7 @@ name: video_player_web
 description: Web platform implementation of video_player
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web
-version: 0.0.1
+version: 0.1.0
 
 flutter:
   plugin:

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`		`-## 0.0.1`
	`1`	`+## 0.1.0`
`2`	`2`
`3`	`3`	`* Initial release`