[camera]skip app delegate during unit test (#4729)

hellohuanlin · web-flow · commit a9316552863b · 2022-02-09T14:50:23.000-08:00
diff --git a/packages/camera/camera/CHANGELOG.md b/packages/camera/camera/CHANGELOG.md
@@ -1,3 +1,7 @@
+## NEXT
+
+* Skips unnecessary AppDelegate setup for unit tests on iOS.
+  
 ## 0.9.4+11
 
 * Manages iOS camera's orientation-related states on a background queue to prevent potential race conditions. 
diff --git a/packages/camera/camera/example/ios/Runner/main.m b/packages/camera/camera/example/ios/Runner/main.m
@@ -8,6 +8,12 @@
 
 int main(int argc, char *argv[]) {
   @autoreleasepool {
-    return UIApplicationMain(argc, argv, nil, NSStringFromClass([AppDelegate class]));
+    // The setup logic in `AppDelegate::didFinishLaunchingWithOptions:` eventually sends camera
+    // operations on the background queue, which would run concurrently with the test cases during
+    // unit tests, making the debugging process confusing. This setup is actually not necessary for
+    // the unit tests, so here we want to skip the AppDelegate when running unit tests.
+    BOOL isTesting = NSClassFromString(@"XCTestCase") != nil;
+    return UIApplicationMain(argc, argv, nil,
+                             isTesting ? nil : NSStringFromClass([AppDelegate class]));
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,12 @@`
`8`	`8`
`9`	`9`	`int main(int argc, char *argv[]) {`
`10`	`10`	`@autoreleasepool {`
`11`		`- return UIApplicationMain(argc, argv, nil, NSStringFromClass([AppDelegate class]));`
	`11`	+ // The setup logic in `AppDelegate::didFinishLaunchingWithOptions:` eventually sends camera
	`12`	`+ // operations on the background queue, which would run concurrently with the test cases during`
	`13`	`+ // unit tests, making the debugging process confusing. This setup is actually not necessary for`
	`14`	`+ // the unit tests, so here we want to skip the AppDelegate when running unit tests.`
	`15`	`+ BOOL isTesting = NSClassFromString(@"XCTestCase") != nil;`
	`16`	`+ return UIApplicationMain(argc, argv, nil,`
	`17`	`+ isTesting ? nil : NSStringFromClass([AppDelegate class]));`
`12`	`18`	`}`
`13`	`19`	`}`