[camera]: temporary patch to avoid camera init crash on android 13 caused by a deprecated video profile object

David Roume · David Roume · commit abaff5a32885 · 2023-01-05T12:05:19.000+01:00
diff --git a/packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/features/resolution/ResolutionFeature.java b/packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/features/resolution/ResolutionFeature.java
@@ -111,16 +111,37 @@ public void updateBuilder(CaptureRequest.Builder requestBuilder) {
   @VisibleForTesting
   static Size computeBestPreviewSize(int cameraId, ResolutionPreset preset)
       throws IndexOutOfBoundsException {
+    // !-------------------------------------------------------
+    // !--- TEMPORARY PATCH ---
+    // ! remove the test below to use higher camera resolution
     // if (preset.ordinal() > ResolutionPreset.high.ordinal()) {
     //   preset = ResolutionPreset.high;
     // }
-    if (Build.VERSION.SDK_INT >= 31) {
+    // !--- END OF TEMPORARY PATCH ---
+    // !-------------------------------------------------------
+
+    // !-------------------------------------------------------
+    // !--- TEMPORARY PATCH ---
+    // ! limiting the condition to Build.VERSION.SDK_INT == 31 && Build.VERSION.SDK_INT == 32 only 
+    // ! to avoid crash on Android 13
+    if (Build.VERSION.SDK_INT >= 31 && Build.VERSION.SDK_INT < 33) {
       EncoderProfiles profile =
           getBestAvailableCamcorderProfileForResolutionPreset(cameraId, preset);
       List<EncoderProfiles.VideoProfile> videoProfiles = profile.getVideoProfiles();
       EncoderProfiles.VideoProfile defaultVideoProfile = videoProfiles.get(0);
-
+ 
       return new Size(defaultVideoProfile.getWidth(), defaultVideoProfile.getHeight());
+    // !-----------------
+    // ! original source
+    // if (Build.VERSION.SDK_INT >= 31) {
+    //   EncoderProfiles profile =
+    //       getBestAvailableCamcorderProfileForResolutionPreset(cameraId, preset);
+    //   List<EncoderProfiles.VideoProfile> videoProfiles = profile.getVideoProfiles();
+    //   EncoderProfiles.VideoProfile defaultVideoProfile = videoProfiles.get(0);
+
+    //   return new Size(defaultVideoProfile.getWidth(), defaultVideoProfile.getHeight());
+    // !--- END OF TEMPORARY PATCH ---
+    // !-------------------------------------------------------
     } else {
       @SuppressWarnings("deprecation")
       CamcorderProfile profile =
