-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: chenshuo/muduo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: flycloud/muduo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 12 commits
- 15 files changed
- 3 contributors
Commits on Nov 17, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 3c64e20 - Browse repository at this point
Copy the full SHA 3c64e20View commit details
Commits on Dec 5, 2016
-
Configuration menu - View commit details
-
Copy full SHA for e209288 - Browse repository at this point
Copy the full SHA e209288View commit details
Commits on Dec 6, 2016
-
Merge pull request #243 from huntinux/master
remove redundant semicolon in buffer.h
Configuration menu - View commit details
-
Copy full SHA for 05b1cb3 - Browse repository at this point
Copy the full SHA 05b1cb3View commit details
Commits on Dec 21, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 7267ff1 - Browse repository at this point
Copy the full SHA 7267ff1View commit details
Commits on Dec 23, 2016
-
High watermark callback should only stop reading peer connection if its output buffer is not empty. Originally, the high watermark callback will stop reading the peer connection and register a write complete callback unconditionally. Consiter two events happening in the same EventLoop iteration: Connection C is readable Connection S is writable In C.onMessage(), it calls S.send(), then decides to queue a high watermark callback because S.outputBuffer is full. S.HWM will be called after event handling. In S.handleWrite(), all data are sent, output buffer becomes empty, but it doesn't queue write complete callback of S because it's not registered yet. In doPendingFunctors(), S.HWM is called, stop reading C, and register a write complete callback for S to re-enable reading C. This will never happen because S has nothing to send, it is already write complete. A false fix: Register write complete callback at beginning, never unregister it. This of course has some performance penalty, but appears to work because in the case of two events above, S.handleWrite() will queue its write complete callback after S.HWM. In doPendingFunctors(), first call S.HWM to stop reading C, then call S.WC to re-enable reading C. This false fix has a subtle dependency on the execution sequence of muduo EventLoop::doPendingFunctors(), and if EventLoop replace the queue with a stack, the program breaks mystically.
Configuration menu - View commit details
-
Copy full SHA for 0502020 - Browse repository at this point
Copy the full SHA 0502020View commit details
Commits on Dec 26, 2016
-
Revert "remove package name in RpcMessage. PROTOCOL CHANGED"
This reverts commit 0197724.
Configuration menu - View commit details
-
Copy full SHA for 27c063d - Browse repository at this point
Copy the full SHA 27c063dView commit details
Commits on Dec 28, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 4019439 - Browse repository at this point
Copy the full SHA 4019439View commit details -
Configuration menu - View commit details
-
Copy full SHA for 219547f - Browse repository at this point
Copy the full SHA 219547fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5327ba - Browse repository at this point
Copy the full SHA a5327baView commit details
Commits on Jan 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 98e027a - Browse repository at this point
Copy the full SHA 98e027aView commit details
Commits on Jan 5, 2017
-
mark committed
Jan 5, 2017 Configuration menu - View commit details
-
Copy full SHA for e7ea913 - Browse repository at this point
Copy the full SHA e7ea913View commit details -
Merge pull request #249 from Markliang1994/master
fix comment error in Atomic.h
Configuration menu - View commit details
-
Copy full SHA for 8973d8f - Browse repository at this point
Copy the full SHA 8973d8fView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master