fix(solid): Fix navigation span test assertions and numeric delta handling

cursoragent · claude · cursoragent · commit 98f020cc692a · 2026-03-30T07:15:32.000Z
- Fix test assertions to check for 'url' source instead of 'route' when
  verifying navigation spans are not created with instrumentNavigation:false.
  The spanStart event captures spans at creation time when source is 'url',
  before the createEffect updates it to 'route'.

- Fix pendingNavigationTarget guard to handle all numeric navigation deltas
  (e.g., -2, -3) not just -1. Previously, numeric deltas beyond -1 would
  block effect updates and prevent route parametrization.

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/packages/solid/src/solidrouter.ts b/packages/solid/src/solidrouter.ts
@@ -91,9 +91,9 @@ function withSentryRouterRoot(Root: Component<RouteSectionProps>): Component<Rou
       // transition completes. In that case, location.pathname still points
       // to the old route while the active span is already the navigation span.
       // Skip the update to avoid overwriting the span with stale route data.
-      // `-1` is solid router's representation of a browser back-button
-      // navigation, where we don't know the target URL upfront.
-      if (pendingNavigationTarget && pendingNavigationTarget !== '-1' && name !== pendingNavigationTarget) {
+      // Numeric deltas (e.g., `-1`, `-2`) are solid router's representation of
+      // browser back/forward navigations, where we don't know the target URL upfront.
+      if (pendingNavigationTarget && !pendingNavigationTarget.match(/^-\d+$/) && name !== pendingNavigationTarget) {
         return;
       }
       pendingNavigationTarget = undefined;
diff --git a/packages/solid/test/solidrouter.test.tsx b/packages/solid/test/solidrouter.test.tsx
@@ -188,7 +188,7 @@ describe('solidRouterBrowserTracingIntegration', () => {
         op: 'navigation',
         description: '/about',
         data: expect.objectContaining({
-          [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
+          [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
           [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
           [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.solid.solidrouter',
         }),
diff --git a/packages/solidstart/test/client/solidrouter.test.tsx b/packages/solidstart/test/client/solidrouter.test.tsx
@@ -188,7 +188,7 @@ describe('solidRouterBrowserTracingIntegration', () => {
         op: 'navigation',
         description: '/about',
         data: expect.objectContaining({
-          [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
+          [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
           [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
           [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.solidstart.solidrouter',
         }),
