Skip to content

New repositories not created during full-sync operation #709

@PendaGTP

Description

@PendaGTP

Problem Description

When running safe-settings via GitHub Actions using the full-sync script, new repositories defined in the configuration are not being created, while all other settings synchronization works as expected.

Current vs Expected Behavior

Currently:

  • Full-sync runs successfully without errors
  • Existing repositories are properly synchronized
  • New repositories defined in config are not created

Expected:

  • New repositories should be created based on the configuration during full-sync

Technical Analysis

The issue stems from different code execution paths:

  1. Normal Operation (Working via webhook)

    • Event triggers syncSettingsSettings.syncSettings.updateRepos
    • Directly processes repositories without filtering
  2. Full-Sync (Not Working)

    • Process: syncInstallationsyncAllSettingsSettings.syncAllSettings.updateAll()
    • updateAll only processes existing repositories via eachRepositoryRepos (which use GET /installation/repositories to filter)
    • Missing: Check for repositories defined in config but not yet created

Environment

  • safe-settings: 2.1.24
  • Platform: github.com
  • Running on: Github Action (cron + manual trigger)
  • Using full-sync script

Related Issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions