Describe the bug
It appears that the implementation of #457 through #458 was broken by #469 if you are not using http remote urls and instead use the SSH/Git remote urls, e.g. <company>@<company>.ghe.com:org/repo.git.
Log output:
Activating GitHub Actions extension...
Error getting GitHub context
Invalid URL
TypeError: Invalid URL
at new URL (node:internal/url:818:25)
at /home/gustav/.vscode-server/extensions/github.vscode-github-actions-0.27.2/dist/extension-node.js:1:1158030
at async Promise.all (index 0)
at async /home/gustav/.vscode-server/extensions/github.vscode-github-actions-0.27.2/dist/extension-node.js:1:1157669
at async De (/home/gustav/.vscode-server/extensions/github.vscode-github-actions-0.27.2/dist/extension-node.js:1:1157518)
at async os (/home/gustav/.vscode-server/extensions/github.vscode-github-actions-0.27.2/dist/extension-node.js:1:1339675)
at async db.n (file:///home/gustav/.vscode-server/bin/488a1f239235055e34e673291fb8d8c810886f81/out/vs/workbench/api/node/extensionHostProcess.js:112:13386)
at async db.m (file:///home/gustav/.vscode-server/bin/488a1f239235055e34e673291fb8d8c810886f81/out/vs/workbench/api/node/extensionHostProcess.js:112:13349)
at async db.l (file:///home/gustav/.vscode-server/bin/488a1f239235055e34e673291fb8d8c810886f81/out/vs/workbench/api/node/extensionHostProcess.js:112:12805)
To Reproduce
Steps to reproduce the behavior:
- Set up a repo on a ghe.com instance. Add VS Code settings as follow:
{
"github-enterprise.uri": "https://<company>.ghe.com",
"github-actions.use-enterprise": true
}
- Check out the repository using the git/ssh remote:
git clone <company>@<company>.ghe.com:org/repo.git
- The Github Actions extension will fail to initialize due to
URL failing to parse <company>@<company>.ghe.com:org/repo.git as a URL which then throws an error which is not handled.
Screenshots
Extension Version
v0.27.2
Additional context
Describe the bug
It appears that the implementation of #457 through #458 was broken by #469 if you are not using http remote urls and instead use the SSH/Git remote urls, e.g.
<company>@<company>.ghe.com:org/repo.git.Log output:
To Reproduce
Steps to reproduce the behavior:
{ "github-enterprise.uri": "https://<company>.ghe.com", "github-actions.use-enterprise": true }URLfailing to parse<company>@<company>.ghe.com:org/repo.gitas a URL which then throws an error which is not handled.Screenshots
Extension Version
v0.27.2Additional context