Fetch 100 codespaces by default

geramirez · web-flow · commit 20ae9d305d13 · 2021-10-06T14:53:55.000Z
diff --git a/internal/codespaces/api/api.go b/internal/codespaces/api/api.go
@@ -196,11 +196,11 @@ type getCodespacesListResponse struct {
 // ListCodespaces returns a list of codespaces for the user.
 // It consumes all pages returned by the API until all codespaces have been fetched.
 func (a *API) ListCodespaces(ctx context.Context) (codespaces []*Codespace, err error) {
-	per_page := 50
+	per_page := 100
 	for page := 1; ; page++ {
-		response, err := a.fetchCodespaces(ctx, page)
+		response, err := a.fetchCodespaces(ctx, page, per_page)
 		if err != nil {
-			return nil, fmt.Errorf("%w", err)
+			return nil, err
 		}
 		codespaces = append(codespaces, response.Codespaces...)
 		if page*per_page >= response.TotalCount {
@@ -211,8 +211,7 @@ func (a *API) ListCodespaces(ctx context.Context) (codespaces []*Codespace, err
 	return codespaces, nil
 }
 
-func (a *API) fetchCodespaces(ctx context.Context, page int) (response *getCodespacesListResponse, err error) {
-	per_page := 50
+func (a *API) fetchCodespaces(ctx context.Context, page int, per_page int) (response *getCodespacesListResponse, err error) {
 	req, err := http.NewRequest(
 		http.MethodGet, a.githubAPI+"/user/codespaces", nil,
 	)
diff --git a/internal/codespaces/api/api_test.go b/internal/codespaces/api/api_test.go
@@ -60,7 +60,7 @@ func createFakeListEndpointServer(t *testing.T, initalTotal int, finalTotal int)
 }
 
 func TestListCodespaces(t *testing.T) {
-	svr := createFakeListEndpointServer(t, 100, 100)
+	svr := createFakeListEndpointServer(t, 200, 200)
 	defer svr.Close()
 
 	api := API{
@@ -73,21 +73,21 @@ func TestListCodespaces(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if len(codespaces) != 100 {
+	if len(codespaces) != 200 {
 		t.Fatalf("expected 100 codespace, got %d", len(codespaces))
 	}
 
 	if codespaces[0].Name != "codespace-0" {
 		t.Fatalf("expected codespace-0, got %s", codespaces[0].Name)
 	}
 
-	if codespaces[99].Name != "codespace-99" {
-		t.Fatalf("expected codespace-99, got %s", codespaces[0].Name)
+	if codespaces[199].Name != "codespace-199" {
+		t.Fatalf("expected codespace-199, got %s", codespaces[0].Name)
 	}
 }
 
 func TestMidIterationDeletion(t *testing.T) {
-	svr := createFakeListEndpointServer(t, 100, 99)
+	svr := createFakeListEndpointServer(t, 200, 199)
 	defer svr.Close()
 
 	api := API{
@@ -100,13 +100,13 @@ func TestMidIterationDeletion(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if len(codespaces) != 100 {
-		t.Fatalf("expected 100 codespace, got %d", len(codespaces))
+	if len(codespaces) != 200 {
+		t.Fatalf("expected 200 codespace, got %d", len(codespaces))
 	}
 }
 
 func TestMidIterationAddition(t *testing.T) {
-	svr := createFakeListEndpointServer(t, 99, 100)
+	svr := createFakeListEndpointServer(t, 199, 200)
 	defer svr.Close()
 
 	api := API{
@@ -119,7 +119,7 @@ func TestMidIterationAddition(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if len(codespaces) != 100 {
-		t.Fatalf("expected 100 codespace, got %d", len(codespaces))
+	if len(codespaces) != 200 {
+		t.Fatalf("expected 200 codespace, got %d", len(codespaces))
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ func createFakeListEndpointServer(t *testing.T, initalTotal int, finalTotal int)`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`func TestListCodespaces(t *testing.T) {`
`63`		`- svr := createFakeListEndpointServer(t, 100, 100)`
	`63`	`+ svr := createFakeListEndpointServer(t, 200, 200)`
`64`	`64`	`defer svr.Close()`
`65`	`65`
`66`	`66`	`api := API{`
`@@ -73,21 +73,21 @@ func TestListCodespaces(t *testing.T) {`
`73`	`73`	`if err != nil {`
`74`	`74`	`t.Fatal(err)`
`75`	`75`	`}`
`76`		`- if len(codespaces) != 100 {`
	`76`	`+ if len(codespaces) != 200 {`
`77`	`77`	`t.Fatalf("expected 100 codespace, got %d", len(codespaces))`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`if codespaces[0].Name != "codespace-0" {`
`81`	`81`	`t.Fatalf("expected codespace-0, got %s", codespaces[0].Name)`
`82`	`82`	`}`
`83`	`83`
`84`		`- if codespaces[99].Name != "codespace-99" {`
`85`		`- t.Fatalf("expected codespace-99, got %s", codespaces[0].Name)`
	`84`	`+ if codespaces[199].Name != "codespace-199" {`
	`85`	`+ t.Fatalf("expected codespace-199, got %s", codespaces[0].Name)`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`func TestMidIterationDeletion(t *testing.T) {`
`90`		`- svr := createFakeListEndpointServer(t, 100, 99)`
	`90`	`+ svr := createFakeListEndpointServer(t, 200, 199)`
`91`	`91`	`defer svr.Close()`
`92`	`92`
`93`	`93`	`api := API{`
`@@ -100,13 +100,13 @@ func TestMidIterationDeletion(t *testing.T) {`
`100`	`100`	`if err != nil {`
`101`	`101`	`t.Fatal(err)`
`102`	`102`	`}`
`103`		`- if len(codespaces) != 100 {`
`104`		`- t.Fatalf("expected 100 codespace, got %d", len(codespaces))`
	`103`	`+ if len(codespaces) != 200 {`
	`104`	`+ t.Fatalf("expected 200 codespace, got %d", len(codespaces))`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`func TestMidIterationAddition(t *testing.T) {`
`109`		`- svr := createFakeListEndpointServer(t, 99, 100)`
	`109`	`+ svr := createFakeListEndpointServer(t, 199, 200)`
`110`	`110`	`defer svr.Close()`
`111`	`111`
`112`	`112`	`api := API{`
`@@ -119,7 +119,7 @@ func TestMidIterationAddition(t *testing.T) {`
`119`	`119`	`if err != nil {`
`120`	`120`	`t.Fatal(err)`
`121`	`121`	`}`
`122`		`- if len(codespaces) != 100 {`
`123`		`- t.Fatalf("expected 100 codespace, got %d", len(codespaces))`
	`122`	`+ if len(codespaces) != 200 {`
	`123`	`+ t.Fatalf("expected 200 codespace, got %d", len(codespaces))`
`124`	`124`	`}`
`125`	`125`	`}`