Skip to content

Commit fdaa48f

Browse files
committed
Resolved Sacret#5
1 parent 3cd9d78 commit fdaa48f

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

js/actions/FilterActions.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ import Reflux from 'reflux';
88
const FilterActions = Reflux.createActions([
99
'getFilters',
1010
'setFilter',
11-
'setFilterTags',
12-
'loadMoreWithFilters'
11+
'setFilterTags'
1312
]);
1413

1514
module.exports = FilterActions;

js/stores/FilterStore.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ const FilterStore = Reflux.createStore({
2525
this.filterInfo.filters = [{
2626
title: 'owner',
2727
active: false
28+
}, {
29+
title: 'forks',
30+
active: false
2831
}, {
2932
title: 'member',
3033
active: false
@@ -71,10 +74,6 @@ const FilterStore = Reflux.createStore({
7174
});
7275
this.filterInfo.reposIds = _(reposIds).flatten().uniq().value();
7376
ReposActions.getRepos(accessToken, 1, this.filterInfo.currentFilter, this.filterInfo.reposIds);
74-
},
75-
76-
loadMoreWithFilters(accessToken, nextPage) {
77-
ReposActions.getRepos(accessToken, nextPage, this.filterInfo.currentFilter, this.filterInfo.reposIds);
7877
}
7978

8079
});

js/stores/ReposStore.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ const ReposStore = Reflux.createStore({
3030
if (this.reposInfo.filter == 'starred') {
3131
reposUrl = 'starred';
3232
}
33+
let includeForks = filter == 'forks';
34+
//
3335
let requestUrl = Config.GithubApiUrl + 'user/' + reposUrl;
3436
let qs = {
3537
access_token: accessToken,
@@ -62,12 +64,13 @@ const ReposStore = Reflux.createStore({
6264
newRepos = res.body;
6365
}
6466
//
65-
let allRepos = _.union(_this.reposInfo.repos, newRepos);
66-
_this.reposInfo.repos = _.uniq(allRepos, (repo) => {
67-
return repo.id;
67+
newRepos = _.filter(newRepos, (repo) => {
68+
return includeForks ? repo.fork : !repo.fork;
6869
});
6970
//
70-
if (res.body.length) {
71+
_this.reposInfo.repos = _.union(_this.reposInfo.repos, newRepos);
72+
//
73+
if (res.body.length == Config.PerPage) {
7174
_this.getRepos(accessToken, page + 1, filter, filterReposIds)
7275
}
7376
_this.trigger(_this.reposInfo);

0 commit comments

Comments
 (0)