Skip to content

Commit ebad530

Browse files
xiaoliu1988leshi
authored andcommitted
Consolidate AppId for web-based and app-based U2F requests. (google#156)
1 parent 100bc55 commit ebad530

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

u2f-gae-demo/src/com/google/u2f/gaedemo/servlets/BeginEnrollServlet.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ public void doPost(HttpServletRequest req, HttpServletResponse resp)
4343
boolean allowReregistration = Boolean.valueOf(req.getParameter("reregistration"));
4444
RegistrationRequest registrationRequest;
4545
U2fSignRequest signRequest;
46-
String appId = (req.isSecure() ? "https://" : "http://") + req.getHeader("Host");
46+
String appId =
47+
(req.isSecure() ? "https://" : "http://") + req.getHeader("Host") + "/origins.json";
4748

4849
try {
4950
registrationRequest = u2fServer.getRegistrationRequest(user.getEmail(), appId);

u2f-gae-demo/src/com/google/u2f/gaedemo/servlets/BeginSignServlet.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ public void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOEx
3939
User user = userService.getCurrentUser();
4040

4141
U2fSignRequest signRequest;
42-
String appId = (req.isSecure() ? "https://" : "http://") + req.getHeader("Host");
42+
String appId =
43+
(req.isSecure() ? "https://" : "http://") + req.getHeader("Host") + "/origins.json";
4344
try {
4445
signRequest = u2fServer.getSignRequest(user.getEmail(), appId);
4546
} catch (U2FException e) {

u2f-gae-demo/war/origins.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
"trustedFacets" : [{
33
"version": { "major": 1, "minor" : 0 },
44
"ids": [
5+
"http://localhost:8888",
6+
"https://u2fdemo.appspot.com",
7+
"https://crxjs-dot-u2fdemo.appspot.com",
8+
"https://noext-dot-u2fdemo.appspot.com",
59
"android:apk-key-hash:bkHnlWEV_jRCPdYGJfwOl7Sn_CLC_2TE3h4TO1_n34I"
610
]
711
}]

0 commit comments

Comments
 (0)