fixed 批量生成接口 报错

stoneworld · web-flow · commit d0dbce72679d · 2018-12-29T12:47:37.000+08:00
报错信息如下：

&gt; Warning: count(): Parameter must be an array or an object that implements Countable in … // PHP 7.2 起

自 PHP 7.2 起 对 count 函数参数类型加了限制，数组或者 `Countable` 对象，所以这里改成 !empty 更为合适并且兼容。
diff --git a/app/Http/Controllers/AdminController.php b/app/Http/Controllers/AdminController.php
@@ -310,7 +310,7 @@ public function batchAddUsers(Request $request)
                 $user->save();
 
                 // 初始化默认标签
-                if (count(self::$systemConfig['initial_labels_for_user']) > 0) {
+                if (!empty(self::$systemConfig['initial_labels_for_user'])) {
                     $labels = explode(',', self::$systemConfig['initial_labels_for_user']);
                     $this->makeUserLabels($user->id, $labels);
                 }
@@ -2437,4 +2437,4 @@ private function makeUserLabels($userId, $labels = [])
             }
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,7 @@ public function batchAddUsers(Request $request)`
`310`	`310`	`$user->save();`
`311`	`311`
`312`	`312`	`// 初始化默认标签`
`313`		`- if (count(self::$systemConfig['initial_labels_for_user']) > 0) {`
	`313`	`+ if (!empty(self::$systemConfig['initial_labels_for_user'])) {`
`314`	`314`	`$labels = explode(',', self::$systemConfig['initial_labels_for_user']);`
`315`	`315`	`$this->makeUserLabels($user->id, $labels);`
`316`	`316`	`}`
`@@ -2437,4 +2437,4 @@ private function makeUserLabels($userId, $labels = [])`
`2437`	`2437`	`}`
`2438`	`2438`	`}`
`2439`	`2439`	`}`
`2440`		`-}`
	`2440`	`+}`