Fixed jenkinsci#282

tuliren · tuliren · commit 4e317ed7cd34 · 2017-09-08T20:25:04.000-07:00
o Check the correct parameter when converting cause
   to a BuildCause object.
diff --git a/ReleaseNotes.md b/ReleaseNotes.md
@@ -2,6 +2,11 @@
 
 ## Release 0.3.8 (NOT RELEASED YET)
 
+ * [Fixed Issue 282][issue-282]
+   
+   `NullPointerException` may be thrown if `upstreamUrl` is `null` when
+   converting cause to `BuildCause` object.
+
  * [Fixed Issue 268][issue-268]
   
    NullPointerException is thrown unless isRunning() is called first.
diff --git a/jenkins-client/src/main/java/com/offbytwo/jenkins/model/BuildWithDetails.java b/jenkins-client/src/main/java/com/offbytwo/jenkins/model/BuildWithDetails.java
@@ -290,7 +290,7 @@ private BuildCause convertToBuildCause(Map<String, Object> cause) {
         }
 
         String upstreamUrl = (String) cause.get("upstreamUrl");
-        if (!Strings.isNullOrEmpty(upstreamProject)) {
+        if (!Strings.isNullOrEmpty(upstreamUrl)) {
             cause_object.setUpstreamUrl(upstreamUrl);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ private BuildCause convertToBuildCause(Map<String, Object> cause) {`
`290`	`290`	`}`
`291`	`291`
`292`	`292`	`String upstreamUrl = (String) cause.get("upstreamUrl");`
`293`		`- if (!Strings.isNullOrEmpty(upstreamProject)) {`
	`293`	`+ if (!Strings.isNullOrEmpty(upstreamUrl)) {`
`294`	`294`	`cause_object.setUpstreamUrl(upstreamUrl);`
`295`	`295`	`}`
`296`	`296`