Bug fix based on tests

kohsuke · kohsuke · commit 25d426f48348 · 2014-05-10T14:03:12.000-07:00
diff --git a/src/main/java/org/kohsuke/github/GHGist.java b/src/main/java/org/kohsuke/github/GHGist.java
@@ -115,7 +115,7 @@ public String getCommentsUrl() {
     }
 
     String getApiTailUrl(String tail) {
-        return "/gist/" + id + '/' + tail;
+        return "/gists/" + id + '/' + tail;
     }
 
     public void star() throws IOException {
@@ -159,6 +159,20 @@ protected void wrapUp(GHGist[] page) {
      * Deletes this gist.
      */
     public void delete() throws IOException {
-        new Requester(root).method("DELETE").to("/gist/" + id);
+        new Requester(root).method("DELETE").to("/gists/" + id);
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        GHGist ghGist = (GHGist) o;
+        return id.equals(ghGist.id);
+
+    }
+
+    @Override
+    public int hashCode() {
+        return id.hashCode();
     }
 }
diff --git a/src/main/java/org/kohsuke/github/GHGistBuilder.java b/src/main/java/org/kohsuke/github/GHGistBuilder.java
@@ -42,6 +42,7 @@ public GHGistBuilder file(String fileName, String content) {
      * Creates a Gist based on the parameters specified thus far.
      */
     public GHGist create() throws IOException {
+        req._with("files",files);
         return req.to("/gists",GHGist.class).wrapUp(root);
     }
 }
diff --git a/src/test/java/org/kohsuke/github/GistTest.java b/src/test/java/org/kohsuke/github/GistTest.java
@@ -0,0 +1,58 @@
+package org.kohsuke.github;
+
+import org.junit.Test;
+
+/**
+ * @author Kohsuke Kawaguchi
+ */
+public class GistTest extends AbstractGitHubApiTestBase {
+    /**
+     * CRUD operation.
+     */
+    @Test
+    public void lifecycleTest() throws Exception {
+        GHGist gist = gitHub.createGist()
+                .public_(false)
+                .description("Test Gist")
+                .file("abc.txt","abc")
+                .file("def.txt","def")
+                .create();
+
+        assertNotNull(gist.getCreatedAt());
+        assertNotNull(gist.getUpdatedAt());
+
+        assertNotNull(gist.getCommentsUrl());
+        assertNotNull(gist.getCommitsUrl());
+        assertNotNull(gist.getGitPullUrl());
+        assertNotNull(gist.getGitPushUrl());
+        assertNotNull(gist.getHtmlUrl());
+
+        gist.delete();
+    }
+
+    @Test
+    public void starTest() throws Exception {
+        GHGist gist = gitHub.getGist("9903708");
+        assertEquals("rtyler",gist.getOwner().getLogin());
+
+        gist.star();
+        assertTrue(gist.isStarred());
+        gist.unstar();
+        assertFalse(gist.isStarred());
+
+        GHGist newGist = gist.fork();
+
+        try {
+            for (GHGist g : gist.listForks()) {
+                if (g.equals(newGist)) {
+                    // expected to find it in the clone list
+                    return;
+                }
+            }
+
+            fail("Expected to find a newly cloned gist");
+        } finally {
+            newGist.delete();
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ public GHGistBuilder file(String fileName, String content) {`
`42`	`42`	`* Creates a Gist based on the parameters specified thus far.`
`43`	`43`	`*/`
`44`	`44`	`public GHGist create() throws IOException {`
	`45`	`+ req._with("files",files);`
`45`	`46`	`return req.to("/gists",GHGist.class).wrapUp(root);`
`46`	`47`	`}`
`47`	`48`	`}`