Merge pull request hub4j#170 from KostyaSha/coverity

kohsuke · kohsuke · commit 7ff97348d985 · 2015-04-13T16:55:24.000-07:00
Improvements
diff --git a/src/main/java/org/kohsuke/github/GHEventPayload.java b/src/main/java/org/kohsuke/github/GHEventPayload.java
@@ -165,6 +165,7 @@ public GHRepository getRepository() {
 
         @Override
         void wrapUp(GitHub root) {
+            super.wrapUp(root);
             if (repository!=null)
                 repository.wrap(root);
         }
diff --git a/src/test/java/org/kohsuke/github/AbstractGitHubApiTestBase.java b/src/test/java/org/kohsuke/github/AbstractGitHubApiTestBase.java
@@ -19,9 +19,9 @@ public void setUp() throws Exception {
         if (f.exists()) {
             // use the non-standard credential preferentially, so that developers of this library do not have
             // to clutter their event stream.
-            gitHub = GitHubBuilder.fromPropertyFile(f.getPath()).build();
+            gitHub = GitHubBuilder.fromPropertyFile(f.getPath()).withRateLimitHandler(RateLimitHandler.FAIL).build();
         } else {
-            gitHub = GitHub.connect();
+            gitHub = GitHubBuilder.fromCredentials().withRateLimitHandler(RateLimitHandler.FAIL).build();
         }
     }
 
diff --git a/src/test/java/org/kohsuke/github/AppTest.java b/src/test/java/org/kohsuke/github/AppTest.java
@@ -673,8 +673,8 @@ public void testReadme() throws IOException {
     public void testTrees() throws IOException {
     	GHTree masterTree = gitHub.getRepository("kohsuke/github-api").getTree("master");
     	boolean foundReadme = false;
-    	for(GHTreeEntry e : masterTree.getTree()){ 
-    		if("readme".equalsIgnoreCase(e.getPath().replaceAll(".md", ""))){
+    	for(GHTreeEntry e : masterTree.getTree()){
+    		if("readme".equalsIgnoreCase(e.getPath().replaceAll("\\.md", ""))){
     			foundReadme = true;
     			break;
     		}

Original file line number	Diff line number	Diff line change
`@@ -165,6 +165,7 @@ public GHRepository getRepository() {`
`165`	`165`
`166`	`166`	`@Override`
`167`	`167`	`void wrapUp(GitHub root) {`
	`168`	`+ super.wrapUp(root);`
`168`	`169`	`if (repository!=null)`
`169`	`170`	`repository.wrap(root);`
`170`	`171`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,9 @@ public void setUp() throws Exception {`
`19`	`19`	`if (f.exists()) {`
`20`	`20`	`// use the non-standard credential preferentially, so that developers of this library do not have`
`21`	`21`	`// to clutter their event stream.`
`22`		`- gitHub = GitHubBuilder.fromPropertyFile(f.getPath()).build();`
	`22`	`+ gitHub = GitHubBuilder.fromPropertyFile(f.getPath()).withRateLimitHandler(RateLimitHandler.FAIL).build();`
`23`	`23`	`} else {`
`24`		`- gitHub = GitHub.connect();`
	`24`	`+ gitHub = GitHubBuilder.fromCredentials().withRateLimitHandler(RateLimitHandler.FAIL).build();`
`25`	`25`	`}`
`26`	`26`	`}`
`27`	`27`