Newly created user object resets root to null.

kohsuke · kohsuke · commit 9afad71b0f6c · 2015-02-15T07:13:33.000-08:00
Fixes issue hub4j#111. Test case from KostyaSha
diff --git a/src/main/java/org/kohsuke/github/GHPullRequest.java b/src/main/java/org/kohsuke/github/GHPullRequest.java
@@ -194,7 +194,7 @@ public int getChangedFiles() throws IOException {
     private void populate() throws IOException {
         if (merged_by!=null)    return; // already populated
 
-        root.retrieve().to(url, this);
+        root.retrieve().to(url, this).wrapUp(owner);
     }
 
     /**
diff --git a/src/test/java/Foo.java b/src/test/java/Foo.java
@@ -1,22 +1,17 @@
-import org.kohsuke.github.GHIssue;
-import org.kohsuke.github.GHOrganization;
-import org.kohsuke.github.GHTeam;
+import org.kohsuke.github.GHRepository;
 import org.kohsuke.github.GitHub;
-import org.kohsuke.github.PagedIterable;
-import org.kohsuke.github.PagedSearchIterable;
 
-import java.util.Arrays;
-import java.util.Map;
+import java.util.Collection;
 
 /**
  * @author Kohsuke Kawaguchi
  */
 public class Foo {
     public static void main(String[] args) throws Exception {
-        PagedSearchIterable<GHIssue> reviewbybees = GitHub.connect().searchIssues().mentions("reviewbybees").isOpen().list();
-        for (GHIssue r : reviewbybees) {
-            System.out.println(r.getTitle());
+        Collection<GHRepository> lst = GitHub.connect().getUser("kohsuke").getRepositories().values();
+        for (GHRepository r : lst) {
+            System.out.println(r.getName());
         }
-        System.out.println("total="+reviewbybees.getTotalCount());
+        System.out.println(lst.size());
     }
 }
diff --git a/src/test/java/org/kohsuke/github/PullRequestTest.java b/src/test/java/org/kohsuke/github/PullRequestTest.java
@@ -38,6 +38,22 @@ public void setAssignee() throws Exception {
         assertEquals(user, getRepository().getPullRequest(p.getNumber()).getAssignee());
     }
 
+    @Test
+    public void testGetUser() throws IOException {
+        GHPullRequest p = getRepository().createPullRequest(rnd.next(), "stable", "master", "## test");
+        GHPullRequest prSingle = getRepository().getPullRequest(p.getNumber());
+        assertNotNull(prSingle.getUser().root);
+        prSingle.getMergeable();
+        assertNotNull(prSingle.getUser().root);
+
+        PagedIterable<GHPullRequest> ghPullRequests = getRepository().listPullRequests(GHIssueState.OPEN);
+        for (GHPullRequest pr : ghPullRequests) {
+            assertNotNull(pr.getUser().root);
+            assertFalse(pr.getMergeable());
+            assertNotNull(pr.getUser().root);
+        }
+    }
+
     @After
     public void cleanUp() throws Exception {
         for (GHPullRequest pr : getRepository().getPullRequests(GHIssueState.OPEN)) {

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ public int getChangedFiles() throws IOException {`
`194`	`194`	`private void populate() throws IOException {`
`195`	`195`	`if (merged_by!=null) return; // already populated`
`196`	`196`
`197`		`- root.retrieve().to(url, this);`
	`197`	`+ root.retrieve().to(url, this).wrapUp(owner);`
`198`	`198`	`}`
`199`	`199`
`200`	`200`	`/**`