Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/codeworld
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: google/codeworld
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: reflexdebug
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 7, 2019

  1. Inspect-style debugging for reflex FRP code.

    @cdsmith
    cdsmith committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    d113066 View commit details
    Browse the repository at this point in the history

  2. Fix cyclic dependency in reflex-with-inspect. 

    The problem was that debugState depended on userPicture, which depended
on logicalInput, which depended on debugState again.  The unnecessary
dependency was from debugState to userPicture, and it came from creating
debugState in connectInspect, which was doing too much.

In the new code, the debugState event is created before the main cycle,
and connected after the main cycle.  This means that the actual
instantiation of debugState happens outside connectInspect, and
connectInspect is merely passed an action to update the state.
    @cdsmith
    cdsmith committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    adee318 View commit details
    Browse the repository at this point in the history

  3. Acknowledge that connectInspect isn't really a reflex function any 

    longer.  It's just a convenience method that operates in plain IO.

It should really be merged with initDebugMode to avoid code duplication.
But I want to get this change into master, so I'll do that as a followup.
    @cdsmith
    cdsmith committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    03c4622 View commit details
    Browse the repository at this point in the history
Loading