You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 29, 2022. It is now read-only.
auth.py uses tostring in exactly 1 place, which causes the following test to fail for me:
ERROR: testSecureAuthSubGetAuthHeader (gdata_tests.auth_test.TokenClassesTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/ccalabro/code/python/gdata-python-client/tests/gdata_tests/auth_test.py", line 514, in testSecureAuthSubGetAuthHeader
auth_header = token.GetAuthHeader('GET', url)
File "/Library/Python/2.7/site-packages/gdata/auth.py", line 943, in GetAuthHeader
sig = encodestring(self.rsa_key.hashAndSign(data).tostring()).rstrip()
AttributeError: 'bytearray' object has no attribute 'tostring'
The output of hashAndSign is a bytearray (for me it is anyway, is it not for the author?), which doesn't have a tostring method, at least, it doesn't in python 2.7.1, which INSTALL.txt claims this project supports. Actually, I can't find any version of python where bytearray has a tostring method. Why not just use str(self.rsa_key.hashAndSign(data)) instead?
I believe this bug was introduced by commit 3c85d33.
auth.pyusestostringin exactly 1 place, which causes the following test to fail for me:The output of
hashAndSignis abytearray(for me it is anyway, is it not for the author?), which doesn't have atostringmethod, at least, it doesn't in python 2.7.1, whichINSTALL.txtclaims this project supports. Actually, I can't find any version of python wherebytearrayhas atostringmethod. Why not just usestr(self.rsa_key.hashAndSign(data))instead?I believe this bug was introduced by commit 3c85d33.