Submitting review c3d32

ojarjur · ojarjur · commit 57c2bf628a79 · 2016-12-19T14:18:15.000-08:00
Update the app and docs to reflect the code now being go-gettable This is in response to feedback in #1. I've also updated the codebase to reflect changes since the `gcloud app` command got moved out of the 'preview' component.
diff --git a/Dockerfile b/Dockerfile
@@ -15,10 +15,6 @@
 FROM gcr.io/google_appengine/go-compat
 
 ENV GOPATH "/app/"
-RUN go get github.com/google/git-appraise/git-appraise && \
-    go get github.com/google/go-github/github && \
-    go get google.golang.org/appengine && \
-    go get golang.org/x/oauth2
+RUN go get github.com/google/git-pull-request-mirror/app
 
-ADD . /app/src/github-mirror
-RUN go build -tags appenginevm -o /app/_ah/exe github-mirror/app
+RUN go build -tags appenginevm -o /app/_ah/exe github.com/google/git-pull-request-mirror/app
diff --git a/README.md b/README.md
@@ -27,18 +27,16 @@ with the `repo` scope, for it to use.
 Setup:
 
 ```shell
-go get github.com/google/git-appraise/git-appraise
-go get github.com/google/go-github/github
-go get golang.org/x/oauth2
-go build -o ~/bin/mirror batch/batch.go
+go get github.com/google/git-pull-request-mirror/batch
+go build -o ~/bin/pr-mirror "${GOPATH}/src/github.com/google/git-pull-request-mirror/batch/batch.go"
 ```
 
 Example Usage (after you've cloned the repo to mirror):
 
 ```shell
 git fetch origin '+refs/pull/*:refs/pull/*'
 git appraise pull
-~/bin/mirror --target ${GITHUB_USER}/${GITHUB_REPO} --local ./ -auth-token ${YOUR_AUTH_TOKEN}
+~/bin/pr-mirror --target ${GITHUB_USER}/${GITHUB_REPO} --local ./ -auth-token ${YOUR_AUTH_TOKEN}
 git appraise pull
 git appraise push
 ```
@@ -55,5 +53,5 @@ It uses the app engine datastore to store its configuration.
 To deploy:
 
 ```shell
-gcloud preview app deploy ./app.yaml
+gcloud app deploy ./app.yaml
 ```
diff --git a/app.yaml b/app.yaml
@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-module: github-mirror
+service: github-mirror
 runtime: custom
 vm: true
 api_version: 1
