Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

Commit ae3c543

Browse files
rajatbhattarajatbhatta
committed
feat: add unit test for DeleteInstanceConfig.
1 parent 9663fe7 commit ae3c543

3 files changed

Lines changed: 40 additions & 0 deletions

File tree

‎google-cloud-spanner/clirr-ignored-differences.xml‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,29 @@
5050
<className>com/google/cloud/spanner/InstanceAdminClient</className>
5151
<method>com.google.api.gax.longrunning.OperationFuture createInstanceConfig(com.google.cloud.spanner.InstanceConfigInfo)</method>
5252
</difference>
53+
<difference>
54+
<differenceType>7012</differenceType>
55+
<className>com/google/cloud/spanner/InstanceAdminClient</className>
56+
<method>com.google.api.gax.longrunning.OperationFuture updateInstanceConfig(com.google.cloud.spanner.InstanceConfigInfo, com.google.cloud.spanner.InstanceConfigInfo$InstanceConfigField[])</method>
57+
</difference>
58+
<difference>
59+
<differenceType>7012</differenceType>
60+
<className>com/google/cloud/spanner/InstanceAdminClient</className>
61+
<method>void deleteInstanceConfig(java.lang.String)</method>
62+
</difference>
5363
<difference>
5464
<differenceType>7012</differenceType>
5565
<className>com/google/cloud/spanner/spi/v1/SpannerRpc</className>
5666
<method>com.google.api.gax.longrunning.OperationFuture createInstanceConfig(java.lang.String, java.lang.String, com.google.spanner.admin.instance.v1.InstanceConfig)</method>
5767
</difference>
68+
<difference>
69+
<differenceType>7012</differenceType>
70+
<className>com/google/cloud/spanner/spi/v1/SpannerRpc</className>
71+
<method>com.google.api.gax.longrunning.OperationFuture updateInstanceConfig(com.google.spanner.admin.instance.v1.InstanceConfig, com.google.protobuf.FieldMask)</method>
72+
</difference>
73+
<difference>
74+
<differenceType>7012</differenceType>
75+
<className>com/google/cloud/spanner/spi/v1/SpannerRpc</className>
76+
<method>void deleteInstanceConfig(java.lang.String)</method>
77+
</difference>
5878
</differences>

‎google-cloud-spanner/src/test/java/com/google/cloud/spanner/InstanceAdminClientImplTest.java‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import com.google.spanner.admin.instance.v1.CreateInstanceConfigMetadata;
4242
import com.google.spanner.admin.instance.v1.CreateInstanceMetadata;
4343
import com.google.spanner.admin.instance.v1.InstanceConfig;
44+
import com.google.spanner.admin.instance.v1.UpdateInstanceConfigMetadata;
4445
import com.google.spanner.admin.instance.v1.UpdateInstanceMetadata;
4546
import java.util.Arrays;
4647
import java.util.List;
@@ -132,6 +133,12 @@ public void getInstanceConfig() {
132133
assertThat(client.getInstanceConfig(CONFIG_ID).getId().getName()).isEqualTo(CONFIG_NAME);
133134
}
134135

136+
@Test
137+
public void dropInstanceConfig() {
138+
client.deleteInstanceConfig(CONFIG_ID);
139+
verify(rpc).deleteInstanceConfig(CONFIG_NAME);
140+
}
141+
135142
@Test
136143
public void listInstanceConfigs() {
137144
String nextToken = "token";

‎samples/snippets/pom.xml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,20 @@
4444
<dependency>
4545
<groupId>com.google.cloud</groupId>
4646
<artifactId>google-cloud-spanner</artifactId>
47+
<version>6.20.1-SNAPSHOT</version>
4748
</dependency>
49+
<dependency>
50+
<groupId>com.google.api.grpc</groupId>
51+
<artifactId>proto-google-cloud-spanner-admin-instance-v1</artifactId>
52+
<version>6.20.1-SNAPSHOT</version>
53+
</dependency>
54+
<dependency>
55+
<groupId>com.google.api.grpc</groupId>
56+
<artifactId>grpc-google-cloud-spanner-admin-instance-v1</artifactId>
57+
<version>6.20.1-SNAPSHOT</version>
58+
</dependency>
59+
60+
4861
<!-- [END spanner_install_with_bom] -->
4962

5063
<dependency>

0 commit comments

Comments
 (0)